Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Mention keyboard controls #4543

Merged
merged 4 commits into from
Mar 20, 2025
Merged

Web: Mention keyboard controls #4543

merged 4 commits into from
Mar 20, 2025

Conversation

latter-bolden
Copy link
Member

Adds a selected mention index that can be controlled with arrow keys. Handles enter to select and escape to dismiss.

@jamesacklin flagging you for UX review.

Fixes TLON-3783

Verified

This commit was created on github.com and signed with GitHub’s verified signature.
Copy link

linear bot commented Mar 20, 2025

Copy link
Member

@jamesacklin jamesacklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sold

Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good, one question on a conditional

@latter-bolden latter-bolden merged commit 591a133 into develop Mar 20, 2025
1 check passed
@latter-bolden latter-bolden deleted the lb/mention-controller branch March 20, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants