Settings Table Refactor #4544
Merged
Settings Table Refactor #4544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release candidate is crashing on logout. The issue is a race condition with clearing the current user ID before all listeners for the settings table are unmounted. Current user ID is the primary key for the settings table, but we don't actually store other user's settings (table only ever has the singleton row).
To fix this I changed the primary key for the settings table to a static string. I also updated the query methods to assume you always want to read/write that singleton without needing to manually pass in a row ID.
Fixes TLON-3832