image-viewer: modal to avoid shrinking drawers #4548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the weird issues we see with shrinking drawers, but I'm noticing that if I view an image from the post in the backscroll and then exit back to the chat channel, I'm brought back to the bottom of the chat |
|
I'm seeing same behavior on develop in a channel that has unreads. I think we're just doing this any time the channel is routed to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TLON-3801 by using a modal to pop the lightbox. This does hide the top level drawer but I figured that was ok. I also removed some cases where images weren't centered or were distorted.