Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: cache vs currencies #17

Open
tomholford opened this issue Dec 20, 2022 · 0 comments
Open

perf: cache vs currencies #17

tomholford opened this issue Dec 20, 2022 · 0 comments

Comments

@tomholford
Copy link
Owner

Use Zustand persist middleware to persist currency options. This will reduce API calls to coingecko, and provide a better UX. Requires refactoring settings state to use Zustand.
tomholford added a commit that referenced this issue Dec 20, 2022
@tomholford
ux: currency picker ehancements

Verified

This commit was created on github.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
80df6c6 
This resolves #6 by:

- adding explainer copy
- spacing out the form
- sorting the values
- disabling the select while loading

Future work to be tracked in another issue:
- mobile UX (#7)
- cache loaded currency options (#17)
@tomholford tomholford mentioned this issue Dec 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomholford