Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ux: currency picker ehancements #18

Merged
merged 1 commit into from
Dec 20, 2022
Merged

ux: currency picker ehancements #18

merged 1 commit into from
Dec 20, 2022
+21 −13

Conversation

tomholford
Copy link
Owner

This resolves #6 by:

  • adding explainer copy
  • spacing out the form
  • sorting the values
  • disabling the select while loading

Future work to be tracked in another issue:

@tomholford
ux: currency picker ehancements
80df6c6 
This resolves #6 by:

- adding explainer copy
- spacing out the form
- sorting the values
- disabling the select while loading

Future work to be tracked in another issue:
- mobile UX (#7)
- cache loaded currency options (#17)
@tomholford tomholford marked this pull request as ready for review December 20, 2022 11:30
@tomholford tomholford merged commit 1a79127 into master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

settings: base currency UX
1 participant
@tomholford