Fixing incompatibility with the easy-fancybox plugin #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easy-fancybox unqueues several fancybox javascript handles where Shashin's handle is also affected. Without the explicit dependency shashin.js would be loaded before the foreign fancybox.js and fail to initialize because of fancybox's absence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest versions of Shashin and easy-fancybox there is an incompatibility regarding loading the fancybox javascript:
Shashin enqueues the fancybox.js under the handle 'fancybox' and easy-fancybox enqueues it under the name 'jquery-fancybox'. Additionally easy-fancybox dequeues every other fancybox dependency. That alone isn't a problem becuase both javascript files are being loaded but the shashin.js is loaded before easy-fancybox's fancybox.js and therefore shashin.js fails to initialize fancybox, aborts its execution and breaks the whole gallery.
This PR fixes this issue by renaming Shashin's handle to 'jquery-fancybox' and making the dependency on fancybox explicit so that Wordpress can resolve it correctly.