Custom play book #61

PineappleChild · 2025-04-01T12:25:51Z

Added a custom playbook form that can generate playbook content using gpt-4o.
The playbook view table shows both built-in and custom playbooks, which are distinguished by a type category on the table.
The custom playbooks have an edit button allowing a user to access and edit the form to change the playbook description and content, along with using AI to generate more/new content, if needed, when editing.
Only custom playbooks can be edited
The edit form follows a similar style to that of the edit monitor, with a delete button in the edit form that asks for confirmation before deleting a custom playbook. If a custom playbook is being used for monitoring, then an error message appears, and the user is prevented from deleting the playbook before deleting the monitoring schedule
The custom playbooks work with both scheduling and the chat(they appear in the scheduling form and can be accessed by both the chat and the scheduling form/scheduler)
The code is split up in a similar way to that of the monitoring folder, with a separate file under db/ for db interactions and a separate file under tools/ for tools used by action.ts
Built-in and Custom playbooks can have their content copied into a new create custom playbook form; there is now a button to carry this out on the playbook table page. Each subsequent copy of the same playbook is identified by a (Copy 1), (Copy 2),...
-The playbook table page only shows the run playbook button; all other features are in a dropdown menu to the right of the run playbook button

…able, and some db connections for the features added

…pt-4o playbook content generation

…book functionality to be more consistent with the style given in editing monitoring schedules edit form

…ok file under the db folder, added some error handling for action.ts and db/custom-playbook

vercel · 2025-04-01T12:25:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
agent	✅ Ready (Inspect)	Visit Preview	Apr 4, 2025 5:18pm

tsg

Left a few comments, but overall looks good!

tsg · 2025-04-02T14:33:06Z

apps/dbagent/src/lib/tools/custom-playbooks.ts

+export async function getCustomPlaybooks(projectId?: string, asUserId?: string): Promise<customPlaybook[]> {
+  if (!projectId) {
+    throw new Error('[INVALID_INPUT] Project ID is required');
+  }


Would it be possible to make projectId required as a parameter? The fact that you have to check for it existing here is dubious.

I looked at the code, and there is no apparent reason for projectId to be an optional parameter. I updated the code to reflect this.

tsg · 2025-04-02T14:38:47Z

apps/dbagent/src/lib/ai/aidba.ts

+export async function getTools(
+  connection: Connection,
+  asUserId?: string,
+  asProjectId?: string


Now I realized it might have worked to use connection.projectId and then you don't need the asProjectId param. Or is there any case when asProjectId would be different from connection.projectId?

The asProjectId parameter is needed when getTools is called in runners.ts as getTools needs schedule.projectId to be passed into the method for the getPlaybooks portion of getTools to work with the scheduler. In all other cases, where getTools is called, connection.projectId is used instead.

I guess we could have used connections.projectId in runners.ts as well, it should be the same. Butthis way is maybe more explicit/clear, and I might have told you to add it :) Let's leave it like this, thanks for checking.

tsg · 2025-04-02T14:41:30Z

apps/dbagent/src/lib/ai/aidba.ts

-        return listPlaybooks();
+        const playbookNames = listPlaybooks();
+        const projectId = asProjectId || connection.projectId;
+        const customPlaybookNames = await actionListCustomPlaybooksNames(projectId, asUserId);


In general I'd say we have stuff in components import stuff from lib but preferably not the other way around. Just to reduce the chances of circular deps.

Since actionListCustomPlaybooksNames really only calls getListOfCustomPlaybooksNames I think you can just call that directly.

Changed the method calls for actionListCustomPlaybooksNames and actionGetCustomPlaybookContent to getListOfCustomPlaybooksNames and getCustomPlaybookContent, respectively, in the aidba.ts file to remove potential circular dependencies.

tsg · 2025-04-02T14:47:19Z

apps/dbagent/src/components/playbooks/action.ts

+}
+
+//get a custom playbook by Name (used in scheduler since names are given though getPlaybook)
+export async function actionGetCustomPlaybookByName(


Is this function used anywhere? I could find any matches.

I agree, there are no references to this method. I will remove it from playbooks/action.ts.

… dependencies for actionGetCustomPlaybookContent and actionGetListOfCustomPlaybooksNames

…this method

…book functionality to be more consistent with the style given in editing monitoring schedules edit form

…ry to delete it, they are unable to delete the playbook until it is deleted from the scheduler

…ser is warned if a playbook is being used for monitoring when they try to delete it, they are unable to delete the playbook until it is deleted from the scheduler

…able page, and added copy playbook feature for custom and built in playbooks

SferaDev

Looks great! My only general comment is that there are many comments that feel redundant with the names of variables or functions. Code organization is good though and the feature seems to work as expected. Thanks!

tsg

Good to merge from my PoV as well. Nice work @PineappleChild

… via a number, eg (copy 1) (copy 2) etc.

PineappleChild added 16 commits March 26, 2025 19:19

added custom playbook form, edit and delete buttons on the playbook t…

45f40f7

…able, and some db connections for the features added

view playbook details now shows details for custom playbooks, added g…

4f16eb0

…pt-4o playbook content generation

changed generate button in customplaybook form to be more descriptive

c7a9258

cleaned up methods for getting playbooks being called unneccessarily

6e427bb

merge attempt

ee7652b

successfully updated to match style changes

98f85bc

added RLS for getting custom playbooks

892ca2b

worked on getting scheduler to run with custom playbooks

f30be6b

custom playbooks can now run on scheduler

1b02d0a

fixed customPlaybook not working in both chat and scheduler

b975421

added a way to edit customPlaybooks and updated the delete customPlay…

912907e

…book functionality to be more consistent with the style given in editing monitoring schedules edit form

trying to apply changes from main to by local branch

24e5939

made changes to try merge

08bc099

cleaned up action.ts file to split up db calls into the custom-playbo…

a71c5d2

…ok file under the db folder, added some error handling for action.ts and db/custom-playbook

Merge remote-tracking branch 'origin/main' into customPlayBook

544d2a1

restructured playbook methods to fit the db and tools format

9092267

PineappleChild requested review from tsg and SferaDev April 1, 2025 12:25

tsg reviewed Apr 2, 2025

View reviewed changes

projectId in getCustomPlaybooks is no longer an optional parameter

c85cb87

vercel bot deployed to Preview April 2, 2025 16:20 View deployment

changed getPlaybook in getTools method in aidba.ts to remove circular…

3332666

… dependencies for actionGetCustomPlaybookContent and actionGetListOfCustomPlaybooksNames

vercel bot deployed to Preview April 2, 2025 16:48 View deployment

removed actionGetCustomPlaybookByName as there were no references to …

ae27710

…this method

vercel bot deployed to Preview April 2, 2025 16:55 View deployment

added a way to edit customPlaybooks and updated the delete customPlay…

6bc8812

…book functionality to be more consistent with the style given in editing monitoring schedules edit form

vercel bot deployed to Preview April 2, 2025 18:42 View deployment

PineappleChild added 2 commits April 3, 2025 02:13

user is warned if a playbook is being used for monitoring when they t…

1a00764

…ry to delete it, they are unable to delete the playbook until it is deleted from the scheduler

merged with main branch and fixed merge conflicts in aibda.ts, also u…

22961c3

…ser is warned if a playbook is being used for monitoring when they try to delete it, they are unable to delete the playbook until it is deleted from the scheduler

merged with main branch and fixed merge conflicts in aibda.ts, also u…

0184672

…ser is warned if a playbook is being used for monitoring when they try to delete it, they are unable to delete the playbook until it is deleted from the scheduler

vercel bot deployed to Preview April 3, 2025 02:43 View deployment

PineappleChild requested a review from tsg April 3, 2025 02:44

alexfrancoeur mentioned this pull request Apr 3, 2025

Duplicate / Clone / Copy playbooks #65

Open

added dropdown for all features aside from run playbook on playbook t…

6f7dcf4

…able page, and added copy playbook feature for custom and built in playbooks

vercel bot deployed to Preview April 4, 2025 00:39 View deployment

SferaDev approved these changes Apr 4, 2025

View reviewed changes

tsg approved these changes Apr 4, 2025

View reviewed changes

tsg mentioned this pull request Apr 4, 2025

TargetDB tools connection reuse + concurrency limit #67

Open

copy playbook distingishes different copies of the same playbook name…

49b4dfb

… via a number, eg (copy 1) (copy 2) etc.

PineappleChild requested review from tsg and SferaDev April 4, 2025 17:18

vercel bot deployed to Preview April 4, 2025 17:18 View deployment

tsg mentioned this pull request Apr 7, 2025

Add support for custom playbooks #54

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom play book #61

Custom play book #61

PineappleChild commented Apr 1, 2025 •

edited

Loading

vercel bot commented Apr 1, 2025 •

edited

Loading

tsg left a comment

tsg Apr 2, 2025

PineappleChild Apr 2, 2025

tsg Apr 2, 2025

PineappleChild Apr 2, 2025

tsg Apr 2, 2025

tsg Apr 2, 2025

PineappleChild Apr 2, 2025

tsg Apr 2, 2025

PineappleChild Apr 2, 2025

SferaDev left a comment

tsg left a comment

Custom play book #61

Are you sure you want to change the base?

Custom play book #61

Conversation

PineappleChild commented Apr 1, 2025 • edited Loading

vercel bot commented Apr 1, 2025 • edited Loading

tsg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SferaDev left a comment

Choose a reason for hiding this comment

tsg left a comment

Choose a reason for hiding this comment

PineappleChild commented Apr 1, 2025 •

edited

Loading

vercel bot commented Apr 1, 2025 •

edited

Loading