This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Repackage TorBrowser macOS developer signed binaries #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an immediate solution to #66 , binaries from TorBrowser for macOS have been repackaged. These binaries are developer
codesigned by the TorProject, and work for macOSaarch64as confirmed in 05nelsonm/kmp-tor#285 (comment)The TorBrowser binaries for macOS work for both
aarch64andx86_64, so those packaged inkmp-tor-binary-macosx64andkmp-tor-binary-macosarm64are the same (as represented by their respectiveTorResource*objectsha256sumvalues).This PR also temporarily comments out the
kmp-tor-binary-extractJS tests andnpmdependencies, otherwise it would produce a build failure. This will be re-enabled upon release of4.7.13-2