Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix note input padding or expected output notes #598

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

bobbinth
Copy link
Contributor

This PR puts note inputs for the expected output notes under a different key so that we can put un-padded note inputs into the advice provider.

This is a temporary fix as note inputs should always be under the same key (the note input commitment). The proper approach would be to store note inputs in the advice map as follows:

note_inputs_commitment |-> [num_inputs, padded_inputs]

@bobbinth bobbinth requested a review from igamigo April 11, 2024 20:10
@bobbinth bobbinth force-pushed the bobbin-note-input-padding branch from 4e045d1 to 3b23ade Compare April 11, 2024 20:12
Copy link
Collaborator

@igamigo igamigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbinth bobbinth merged commit 03b16d4 into next Apr 11, 2024
9 checks passed
@bobbinth bobbinth deleted the bobbin-note-input-padding branch April 11, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants