Allow increasing an account's nonce without changing its state #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Jul 15, 2024
Fumuran
force-pushed
the
andrew-remove-nonce-restriction
branch
from
0f09350 to
f5f10d1
Compare
bobbinth
approved these changes
Jul 16, 2024
miden-tx/src/tests/mod.rs
Outdated
|
|
||
| ## ACCOUNT PROCEDURE WRAPPERS | ||
| ## ======================================================================================== | ||
| #TODO: Move this into an account library |
There was a problem hiding this comment.
What does this TODO mean here?
There was a problem hiding this comment.
I think the initial idea was to move account procedure wrappers to the library, but I'm not sure that it is valid for my test. I'll remove this line.
miden-tx/src/tests/mod.rs
Outdated
Comment on lines
401
to
407
| proc.incr_nonce | ||
| call.{ACCOUNT_INCR_NONCE_MAST_ROOT} | ||
| # => [0] | ||
|
|
||
| drop | ||
| # => [] | ||
| end |
There was a problem hiding this comment.
Do we actually need this as a separate procedure? Seems simple enough to be just inside the begin ... end statements below.
miden-tx/src/tests/mod.rs
Outdated
Comment on lines
412
to
413
| ## Update the account nonce | ||
| ## ------------------------------------------------------------------------------------ |
There was a problem hiding this comment.
I'm not sure this header here is helpful as the script is simple enough (similar comment about some other headers in this script).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR removes the restriction from nonce to be changed without changing the account state, which was suggested in the related issue: #765.