Made node_index_in_block method return u32
#814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Aug 2, 2024
objects/src/notes/location.rs
Outdated
Comment on lines
27
to
29
| /// The height of the Merkle tree is `BLOCK_OUTPUT_NOTES_TREE_DEPTH`. Thus, the maximum index | ||
| /// is `2 ^ BLOCK_OUTPUT_NOTES_TREE_DEPTH - 1`. | ||
| pub fn node_index_in_block(&self) -> u64 { | ||
| self.node_index_in_block as u64 | ||
| pub fn node_index_in_block(&self) -> u32 { |
There was a problem hiding this comment.
I would rename the constant mentioned here to just BLOCK_NOTES_TREE_DEPTH and also change this to be a link to the constant - i.e., [BLOCK_NOTES_TREE_DEPTH].
Similarly, I'd rename BATCH_OUTPUT_NOTES_TREE_DEPTH to just BATCH_NOTES_TREE_DEPTH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had changed construction of
node_index_in_blocktou32, but the getter still converts it tou64. This PR fixes that.