Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement serialization and Eq for TransactionScript #824

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

tomyrd
Copy link
Collaborator

@tomyrd tomyrd commented Aug 9, 2024

Addresses this comment from miden-client.

Implements Serializable, Deserializable and derives PartialEq and Eq for TransactionScript. These changes are needed to implement the serialization of TransactionRequest in miden-client.

@tomyrd tomyrd force-pushed the tomyrd-serialize-transaction-script branch from 3ad3c1c to 1457a0a Compare August 9, 2024 21:10
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@tomyrd tomyrd force-pushed the tomyrd-serialize-transaction-script branch from 1457a0a to 5461c71 Compare August 9, 2024 21:13
@tomyrd tomyrd marked this pull request as ready for review August 9, 2024 21:13
@tomyrd
Copy link
Collaborator Author

tomyrd commented Aug 9, 2024

Sorry, had to fix the first commit as it had a lint error.

@bobbinth bobbinth merged commit 19c750f into next Aug 9, 2024
13 checks passed
@bobbinth bobbinth deleted the tomyrd-serialize-transaction-script branch August 9, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants