feat: add remote block prover as optional #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantiagoPittella
force-pushed
the
santiagopittella-use-remote-block-prover
branch
from
7b5d726 to
2d25220
Compare
Mirko-von-Leipzig
approved these changes
Feb 25, 2025
SantiagoPittella
force-pushed
the
santiagopittella-use-remote-batch-prover
branch
from
99be9e4 to
c0e0b04
Compare
SantiagoPittella
force-pushed
the
santiagopittella-use-remote-block-prover
branch
from
baf3f44 to
3fdeddb
Compare
docs: add PR number to Changelog remove remote prover from CI and makefile remove remote prover from README feat: create BatchProver enum, make remote proving optional update to latest changes in miden-base fix: udpate with miden-base latest review: use multiple statements to print the configs review: replace warn! with info! in prover init review: add instrumentation to batch prover review: rename remote_batch_prover to batch_prover_url review: remove default batch prover url constant review: move the batch_prover field from BatchProducer to BatchBuilder fix: rollback changes in Makefile docs: update CHANGELOG, add change to readme fix: make it compatible with miden-base
SantiagoPittella
force-pushed
the
santiagopittella-use-remote-batch-prover
branch
from
c0e0b04 to
7b80750
Compare
SantiagoPittella
force-pushed
the
santiagopittella-use-remote-block-prover
branch
from
3fdeddb to
dcb309a
Compare
docs: add changelog entry docs: update readme fix: make it compatible with miden-base
SantiagoPittella
force-pushed
the
santiagopittella-use-remote-block-prover
branch
from
dcb309a to
613b842
Compare
Base automatically changed from
santiagopittella-use-remote-batch-prover
to
next
March 9, 2025 21:20
bobbinth
approved these changes
Mar 9, 2025
Comment on lines
+377
to
+380
| pub fn new_remote(endpoint: impl Into<String>) -> Self { | ||
| info!(target: COMPONENT, "Using remote block prover"); | ||
| Self::Remote(RemoteBlockProver::new(endpoint)) | ||
| } |
There was a problem hiding this comment.
Similar comment here re specifying the security level and then making sure that generated proofs comply with it as in the other PR.
This was referenced Mar 9, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #717