Implement more optimized version of u32lt
#1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Looks good! Thank you! Before merging this, let's have a PR in miden-base to make sure we can have all the tests there working with these changes applies.
Also, I don't think this would affect field operation comparisons (lt, gt, etc.) - but could you double-check if anything there can be improved as well?
Fumuran
commented
Jan 12, 2024
Fumuran
force-pushed
the
andrew-optimize-u32lt
branch
from
37edd79 to
a36103d
Compare
bobbinth
approved these changes
Jan 12, 2024
bobbinth
force-pushed
the
andrew-optimize-u32lt
branch
from
a36103d to
52e972b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR optimizes the
u32ltinstruction, reducing the number of cycles by 2: from 5 to 3. Number of cycles required for instructionsu32lte,u32gtandu32gtewas also reduced by 2, since these instructions were usingu32ltinternally.As it was mentioned in the related issue (#1190), this change will bleak the tests in the
miden-base, so we need to change the hardcoded roots there before merge.