-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing to the Host
interface
#1198
Conversation
Host
interface
3c19637
to
ddc0874
Compare
ddc0874
to
01d8984
Compare
I'm not sure where should we place the documentation for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few comments inline.
I'm not sure where should we place the documentation for the
trace
instruction. I can create another file and place it near theevent
doc file, but they'll be very similar. Should we merge them to create something likeEmitting
file with docs for bothtrace
andevent
?
Yes, but I'd just use the same Events
file and create a "Tracing" section in that file.
Also, looking at this now, I wonder if tracing can replace debug
instruction. I think we can get all the same info from both - but there are different pros and cons. Let's create an issue for this.
73ae361
to
a24f896
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you!
This PR:
trace.<trace_id>
"decorator" instruction to the assemblyon_trace()
method to theHost
trait to handletrace
instructionsTODO: