Program serialization updates #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitwalker
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
The compiler doesn't need to encode the AST in binary form for anything at the moment, so that should be fine - the key thing is preserving the encoding of source locations in MAST as we evolve how debuginfo is handled. This PR doesn't change that, so I don't see any issues with removing all of this code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two main changes:
Programstruct (this is needed inmiden-base). As a part of this changeAstSerdeOptions::serialize_importswas removed as it is no longer relevant.As a part of the second change, I also removed ability to serialize libraries "with options" (and as a result, removed
AstSerdeOptionsstruct entirely). I think this is fine as the only option there was whether we want to serialize debug info or not, but this part wasn't really working anyways (e.g., it didn't affect howAsmOpdecorators are serialized) and I also think we should rework debug info serialization as discussed in #1440.