Check base field #55
Check base field #55
Conversation
| @@ -47,135 +47,3 @@ fn fri_l(codeword_len: usize, rate_log: usize, conjecture: bool) -> f64 { | |||
| 1.0 / (2.0 * EPSILON * rate.sqrt()) | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
There was a problem hiding this comment.
It's a bit annoying having to remove these tests, but since the FRI API is now very PLONK specific it doesn't make sense to update these tests since they'll end up being the same as those in commitment.rs.
If we need FRI for something other that polynomial commitments in the future, we could add some kind of FriInitialData trait and make the FRI API more general.
wborgeaud
force-pushed
the
check_base_field
branch
from
82dd10a to
9eb35c3
Compare
| @@ -142,29 +143,84 @@ fn fri_verify_initial_proof<F: Field>( | |||
| fn fri_combine_initial<F: Field + Extendable<D>, const D: usize>( | |||
There was a problem hiding this comment.
I feel this is getting pretty complicated; I tried to refactor a bit here, though with limited success. I guess there's only so much we can do.
- I tried using the
powers()iterator to supply all the powers of alpha, instead of trackingcur_alphaandpoly_count. Since (currently) we multiply a few things by the same power of alpha, I had to clone the iterator in a few places. - Added an
unsalted_evalshelper - Converted
subgroup_xonce at the beginning - Added a comment
What do you think? Feel free to pick any changes you like and ignore the rest.
There was a problem hiding this comment.
Thanks for the tweaks, they're all great! I've merged them all.
zetaandg*zeta.ListPolynomialCommitmentAPI to be more PLONK specific.