Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the Slider including the "Spnsored by.." und Headline #43

Closed
5 tasks done
mheob opened this issue Dec 2, 2020 · 1 comment · Fixed by #55 or #62
Closed
5 tasks done

Improve the Slider including the "Spnsored by.." und Headline #43

mheob opened this issue Dec 2, 2020 · 1 comment · Fixed by #55 or #62
Assignees
@mheob
Labels
bug Something isn't working pre release Necessary before a release is possible released styling Improve the styling
Milestone
1.0

Comments

@mheob
Copy link
Contributor

mheob commented Dec 2, 2020 •
edited
Loading

Original from Teams-Channel:

Morjeee, an der "Spnsored by.." und Headline auf dem Slider muss noch unbedingt gearbeitet werden. Ist es möglich, dass die Headline größer und unter dem Bild erscheint? Ich mache gleich mal ein Beispiel in XD.

Procedure

  • generate a tweaked theme in Adobe XD (@comarko)
  • implement the changes in the code (@mheob)
    • title should move under the picture (like in the featured slider)
    • font family could be like in the post title
    • horizontal padding should match the previews
@mheob mheob added bug Something isn't working pre release Necessary before a release is possible styling Improve the styling labels Dec 2, 2020
@mheob mheob added this to the 1.0 milestone Dec 2, 2020
@mheob mheob mentioned this issue Dec 2, 2020
Closed
This was referenced Dec 8, 2020
Closed
Merged
Merged
mheob added a commit that referenced this issue Dec 9, 2020
@mheob
feat(home): improve the featured slider and sponsored preview (#59)
b22e434 
* feat(article): improve the sponsored by content
* feat(home): improve the content of the featured slider

Move the title below the image and place the sponsored by content more prominent.

Resolves #43
@mheob mheob closed this as completed in #55 Dec 9, 2020
mheob added a commit that referenced this issue Dec 9, 2020
@mheob
chore: fixes and improvements after closed beta tests (#55)
66aa899 
* fix(home): display the pinned article only if pinned is selected (#53)
  fixes #52
* feat(settings): add a link to write email to convention team (#54)
* feat(settings): add a link to write an email to the convertion team
  resolves #51
* style: fix unused import of settingArray (from lgtm)
* feat(article): improve general UI and UX (#56)
* feat(article): increase the body text and line height a bit
* fix(article): hide unneeded navigation of post slideshow
* feat(article): remove DETAILS buttons and link complete preview
  resolves #49
* feat(home): improve the featured slider and sponsored preview (#59)
* feat(article): improve the sponsored by content
* feat(home): improve the content of the featured slider
  Move the title below the image and place the sponsored by content more prominent.
  resolves #43
* feat(app): add optimized app icons and splash screen (#60)
  resolves #41
* build: add the target as archive for iOS builds
@mheob mheob mentioned this issue Dec 9, 2020
Merged
mheob pushed a commit that referenced this issue Dec 9, 2020
@semantic-release-bot
chore(release): 1.1.0 [skip ci]
81e9e7a 
# [1.1.0](v1.0.0...v1.1.0) (2020-12-09)

### Bug Fixes

* **home:** display the pinned article only if pinned is selected ([#53](#53)) ([6391c83](6391c83)), closes [#52](#52)

### Features

* **app:** add optimized app icons and splash screen ([#60](#60)) ([a529a50](a529a50)), closes [#41](#41)
* **article:** improve general UI and UX ([#56](#56)) ([8934b7c](8934b7c)), closes [#49](#49)
* **home:** improve the featured slider and sponsored preview ([#59](#59)) ([b22e434](b22e434)), closes [#43](#43)
* **settings:** add a link to write email to convention team ([#54](#54)) ([280d2ab](280d2ab)), closes [#51](#51)
@mheob
Copy link
Contributor Author

mheob commented Dec 9, 2020

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mheob mheob added the released label Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mheob mheob

Labels
bug Something isn't working pre release Necessary before a release is possible released styling Improve the styling
Projects
None yet
Milestone
1.0
2 participants
@mheob @comarko