[FEATURE] Garder les icones dans les options du pix-select à la même taille (PIX-16568) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr827.review.pix.fr |
Alexandre-Monney
force-pushed
the
pix-16568-add-no-shrink-for-pix-select-options-icon
branch
from
0ee726f to
1667dec
Compare
Alexandre-Monney
added
Func Review OK
Tech review OK
🚀 Ready to Merge
and removed
👀 Func Review Needed
👀 Tech Review Needed
labels
pix-service-auto-merge
deleted the
pix-16568-add-no-shrink-for-pix-select-options-icon
branch
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Feb 14, 2025
# [54.9.0](v54.8.0...v54.9.0) (2025-02-14) ### 🚀 Amélioration - [#827](#827) Garder les icones dans les options du pix-select à la même taille (PIX-16568)
|
🎉 This PR is included in version 54.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Lors d'une PR précédente pour l'ajout d'icônes dans les options d'un Pix-Select, nous n'avions pas fait le test sur tous les navigateurs (Firefox en l'occurrence) et avec une option ayant un texte assez long.
Dans le cas d'un texte long sur Firefox, l'icône était redimensionnée et pouvait devenir toute petite
🎁 Proposition
Ajouter une classe no-shrink dans le fichier SCSS de Pix-Icon afin de pouvoir utiliser ce modifier quand nous en avons besoin
Notamment dans le cas des options du Pix-Select
🌟 Remarques
Pour Firefox ->
Avant :
Après :
🎅 Pour tester
Essayer en local sur firefox sur
http://localhost:4204/select