[TECH] Uniformise le code des fonctionnalités d'organisation sur PixAdmin (PIX-16319). #11272
+529
−639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frinyvonnick
changed the title
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Alexandre-Monney
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
from
7d9f149 to
5d06af8
Compare
frinyvonnick
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
from
5d06af8 to
434bb1b
Compare
Alexandre-Monney
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
2 times, most recently
from
7e43d56 to
6cb9817
Compare
Alexandre-Monney
added
👀 Tech Review Needed
👀 Func Review Needed
Alexandre-Monney
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
2 times, most recently
from
9326e38 to
d6c5cb9
Compare
Alexandre-Monney
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
2 times, most recently
from
a36930a to
1e4a5d5
Compare
|
Prescription: Func OK 🦦 |
lionelB
reviewed
Feb 5, 2025
api/src/organizational-entities/domain/models/OrganizationForAdmin.js
Outdated
Show resolved
Hide resolved
lionelB
reviewed
Feb 5, 2025
...src/organizational-entities/infrastructure/repositories/organization-for-admin.repository.js
Show resolved
Hide resolved
lionelB
approved these changes
Feb 5, 2025
Alexandre-Monney
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
from
1e4a5d5 to
bb66a2e
Compare
bpetetot
reviewed
Feb 10, 2025
| this.form.identityProviderForCampaigns = | ||
| this.args.organization.identityProviderForCampaigns ?? this.noIdentityProviderOption.value; | ||
|
|
||
| this.form.features = JSON.parse(JSON.stringify(this.args.organization.features)); |
There was a problem hiding this comment.
C'est étrange comme façon de faire, pourquoi doit-on faire ça ?
There was a problem hiding this comment.
On doit faire ça parce que sinon on travaille sur la même référence et on veut pouvoir annuler les changements dans le formulaire donc il faut faire une copie 🤔
There was a problem hiding this comment.
En fouillant un peu, je viens de voir qu'il existait en natif depuis window la méthode structuredClone()
Je vais essayer de voir si je peux pas plutôt utiliser ça a la place du .parse/.stringify
There was a problem hiding this comment.
La méthode structuredClone() marche très bien pour notre cas, je change par ça. Ça rends + explicite à mon avis
admin/app/components/organizations/information-section-edit.gjs
Outdated
Show resolved
Hide resolved
Alexandre-Monney
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
from
bb66a2e to
a156aa4
Compare
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Alexandre-Monney
added
Tech Review OK
and removed
👀 Tech Review Needed
👀 Func Review Needed
alicegoarnisson
approved these changes
Feb 13, 2025
…ures in OrganizationForAdmin model
pix-service-auto-merge
force-pushed
the
pix-16319-refactor-feature-code-in-pix-admin
branch
from
a156aa4 to
ab38dc1
Compare
pix-service-auto-merge
deleted the
pix-16319-refactor-feature-code-in-pix-admin
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Il existe dans la base de code plusieurs manière d'activer des fonctionnalités sur une organisation.
🥓 Proposition
Dans cette PR, on uniformise la manière d'afficher et mettre à jour les fonctionnalités d'une organisation sur PixAdmin via le model OrganizationForAdmin.
🧃 Remarques
La valeur pour la feature attestation est en dur. Il faudra faire évoluer à l'ajout de l'attestation parentalité.
😋 Pour tester
Aller sur PixAdmin
Aller sur la page d'une organisation
Vérifier le bon affichage des features dans l'encart "fonctionnalités"
Vérifier le bon fonctionnement lors de l'édition et l'ajout/retrait des features
(note : il est normal que certaines fonctionnalités se soient pas éditable)