Merge pull request #10578 from 18F/stages/rc-2024-05-09

Deploy RC 378 to Production
18F · May 9, 2024 · 0f0c08d · 0f0c08d
2 parents 5e16c87 + 44c9479
commit 0f0c08d
Show file tree

Hide file tree

Showing 166 changed files with 3,296 additions and 1,267 deletions.
diff --git a/.stylelintrc.json b/.stylelintrc.json
@@ -1,5 +1,4 @@
 {
   "extends": "@18f/identity-stylelint-config",
-  "ignoreFiles": "**/fixtures/**/*",
-  "reportNeedlessDisables": true
+  "ignoreFiles": "**/fixtures/**/*"
 }
diff --git a/app/assets/stylesheets/components/_alert-icon.scss b/app/assets/stylesheets/components/_alert-icon.scss
@@ -7,6 +7,6 @@
 .alert-icon--centered-top {
   position: absolute;
   left: 50%;
-  top: 0px;
+  top: 0;
   transform: translate(-50%, -50%);
 }
diff --git a/app/assets/stylesheets/components/_block-link.scss b/app/assets/stylesheets/components/_block-link.scss
@@ -24,13 +24,10 @@
     &::before {
       @include u-border('1px', 'primary');
       border-radius: 6px;
-      bottom: 0;
+      inset: 0 units(-1) 0 units(-1);
       content: '';
-      left: units(-1);
       pointer-events: none;
       position: absolute;
-      right: units(-1);
-      top: 0;
     }
   }
 }

diff --git a/app/assets/stylesheets/components/_full-screen.scss b/app/assets/stylesheets/components/_full-screen.scss
@@ -5,11 +5,8 @@
 }
 
 .full-screen {
-  bottom: 0;
-  left: 0;
+  inset: 0;
   position: fixed;
-  right: 0;
-  top: 0;
   z-index: 1000;
 }
 

diff --git a/app/assets/stylesheets/components/_spinner-dots.scss b/app/assets/stylesheets/components/_spinner-dots.scss
@@ -65,7 +65,7 @@
     animation-iteration-count: infinite;
     animation-timing-function: linear;
     animation-delay: 0.01s; // See: https://stackoverflow.com/a/40028240
-    background-color: currentColor;
+    background-color: currentcolor;
     border-radius: 50%;
     content: '';
     display: block;

diff --git a/app/assets/stylesheets/components/_step-indicator.scss b/app/assets/stylesheets/components/_step-indicator.scss
@@ -6,7 +6,7 @@ $step-indicator-line-height: 4px;
 lg-step-indicator {
   display: block;
   border-bottom: 1px solid color('primary-light');
-  box-shadow: 0 2px 2px rgba(0, 0, 0, 0.1);
+  box-shadow: 0 2px 2px rgb(0 0 0 / 10%);
   margin-bottom: units(4);
   position: relative;
 
@@ -29,9 +29,9 @@ lg-step-indicator {
     &::before {
       background: linear-gradient(
         to right,
-        rgba(255, 255, 255, 1),
-        rgba(255, 255, 255, 1) 17%,
-        rgba(255, 255, 255, 0)
+        rgb(255 255 255 / 100%),
+        rgb(255 255 255 / 100%) 17%,
+        rgb(255 255 255 / 0%)
       );
       left: 0;
       z-index: 1;
@@ -40,9 +40,9 @@ lg-step-indicator {
     &::after {
       background: linear-gradient(
         to left,
-        rgba(255, 255, 255, 1),
-        rgba(255, 255, 255, 1) 17%,
-        rgba(255, 255, 255, 0)
+        rgb(255 255 255 / 100%),
+        rgb(255 255 255 / 100%) 17%,
+        rgb(255 255 255 / 0%)
       );
       right: 0;
     }

diff --git a/app/assets/stylesheets/design-system-waiting-room.scss b/app/assets/stylesheets/design-system-waiting-room.scss
@@ -1,7 +1,7 @@
 // To be removed once design system incorporates styles included below.
 
-//basscss-base-typography
-//------------------------------------------------
+// basscss-base-typography
+// ------------------------------------------------
 h1,
 h2,
 h3,
@@ -18,7 +18,7 @@ ul {
 }
 
 // basscss-utility-typography
-//------------------------------------------------
+// ------------------------------------------------
 .break-word {
   word-wrap: break-word;
 }

diff --git a/app/assets/stylesheets/tables-report.css.scss b/app/assets/stylesheets/tables-report.css.scss
@@ -10,7 +10,7 @@
 
 .usa-alert.usa-alert--info.usa-alert--email {
   .usa-alert__body {
-    &:before {
+    &::before {
       background-image: url('email/info.png');
     }
   }

diff --git a/app/assets/stylesheets/variables/_email.scss b/app/assets/stylesheets/variables/_email.scss
@@ -21,8 +21,8 @@ $success-color: #3adb76;
 $warning-color: #ffae00;
 $alert-color: #ec5840;
 $light-gray: #f3f3f3;
-$black: #111111;
-$white: #ffffff;
+$black: #111;
+$white: #fff;
 $gray: #5b616a;
 $medium-gray: #cacaca;
 $dark-gray: #212121;

diff --git a/app/components/badge_component.html.erb b/app/components/badge_component.html.erb
@@ -1,4 +1,4 @@
 <%= content_tag('div', **tag_options, class: ['lg-verification-badge', *tag_options[:class]]) do %>
-  <%= image_tag(asset_path("alerts/#{icon}.svg"), size: 16, alt: '', role: 'img') %>
+  <%= render IconComponent.new(icon:, class: 'text-success') %>
   <%= content %>
 <% end %>
diff --git a/app/components/badge_component.rb b/app/components/badge_component.rb
@@ -2,8 +2,8 @@
 
 class BadgeComponent < BaseComponent
   ICONS = %i[
-    unphishable
-    success
+    lock
+    check_circle
   ].to_set.freeze
 
   attr_reader :icon, :tag_options

diff --git a/app/components/badge_component.scss b/app/components/badge_component.scss
@@ -1 +1,7 @@
+@use 'uswds-core' as *;
 @forward 'usa-verification-badge';
+
+// Upstream: https://github.com/18F/identity-design-system/pull/445
+.lg-verification-badge .usa-icon {
+  margin-right: units(1);
+}
diff --git a/app/components/icon_component.scss b/app/components/icon_component.scss
@@ -5,5 +5,5 @@
 
 .icon {
   mask-size: 100%;
-  background-color: currentColor;
+  background-color: currentcolor;
 }
diff --git a/app/components/phone_input_component.scss b/app/components/phone_input_component.scss
@@ -10,7 +10,7 @@ lg-phone-input {
   .iti__flag {
     background-image: url('/flags.png');
 
-    @media (-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi) {
+    @media (resolution >= 2x) {
       background-image: url('/flags@2x.png');
     }
   }

diff --git a/app/components/security_key_image_component.scss b/app/components/security_key_image_component.scss
@@ -1,13 +1,13 @@
 .security-key-image__key {
-  animation: security-key-image__key__move 4s ease-in-out infinite;
+  animation: security-key-image-key-move 4s ease-in-out infinite;
 
   @media (prefers-reduced-motion) {
     animation: none;
   }
 }
 
 .security-key-image__arrow {
-  animation: security-key-image__arrow__move 4s ease-in-out infinite;
+  animation: security-key-image-arrow-move 4s ease-in-out infinite;
 
   @media (prefers-reduced-motion) {
     animation: none;
@@ -16,15 +16,15 @@
 
 .security-key--mobile {
   .security-key-image__key {
-    animation-name: security-key-image__key__move__mobile;
+    animation-name: security-key-image-key-move-mobile;
   }
 
   .security-key-image__arrow {
-    animation-name: security-key-image__arrow__move__mobile;
+    animation-name: security-key-image-arrow-move-mobile;
   }
 }
 
-@keyframes security-key-image__key__move {
+@keyframes security-key-image-key-move {
   25% {
     transform: translate(0, 0);
   }
@@ -39,7 +39,7 @@
   }
 }
 
-@keyframes security-key-image__key__move__mobile {
+@keyframes security-key-image-key-move-mobile {
   25% {
     transform: translate(0, 0);
   }
@@ -54,7 +54,7 @@
   }
 }
 
-@keyframes security-key-image__arrow__move {
+@keyframes security-key-image-arrow-move {
   7.5% {
     transform: translate(0, 0);
   }
@@ -75,7 +75,7 @@
   }
 }
 
-@keyframes security-key-image__arrow__move__mobile {
+@keyframes security-key-image-arrow-move-mobile {
   7.5% {
     transform: translate(0, 0);
   }

diff --git a/app/components/webauthn_input_component.scss b/app/components/webauthn_input_component.scss
@@ -1,3 +1,3 @@
 .webauthn-input--unsupported-passkey .usa-checkbox__label {
-  background: rgba(255, 0, 0, 0.1);
+  background: rgb(255 0 0 / 10%);
 }
diff --git a/app/controllers/completions_cancellation_controller.rb b/app/controllers/completions_cancellation_controller.rb
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class CompletionsCancellationController < ApplicationController
+  before_action :confirm_two_factor_authenticated
+
+  def show
+    analytics.completions_cancellation_visited
+  end
+end
diff --git a/app/controllers/concerns/idv/document_capture_concern.rb b/app/controllers/concerns/idv/document_capture_concern.rb
@@ -49,7 +49,9 @@ def stored_result
     end
 
     def selfie_requirement_met?
-      !decorated_sp_session.biometric_comparison_required? || stored_result.selfie_check_performed?
+      !FeatureManagement.idv_allow_selfie_check? ||
+        !resolved_authn_context_result.biometric_comparison? ||
+        stored_result.selfie_check_performed?
     end
 
     private

diff --git a/app/controllers/concerns/idv/step_indicator_concern.rb b/app/controllers/concerns/idv/step_indicator_concern.rb
@@ -8,15 +8,15 @@ module StepIndicatorConcern
       { name: :getting_started },
       { name: :verify_id },
       { name: :verify_info },
-      { name: :verify_phone_or_address },
-      { name: :secure_account },
+      { name: :verify_phone },
+      { name: :re_enter_password },
     ].freeze
 
     STEP_INDICATOR_STEPS_GPO = [
       { name: :getting_started },
       { name: :verify_id },
       { name: :verify_info },
-      { name: :get_a_letter },
+      { name: :verify_address },
       { name: :secure_account },
     ].freeze
 

diff --git a/app/controllers/concerns/idv_session_concern.rb b/app/controllers/concerns/idv_session_concern.rb
@@ -67,7 +67,8 @@ def idv_session_user
   end
 
   def user_needs_biometric_comparison?
-    decorated_sp_session.biometric_comparison_required? &&
+    FeatureManagement.idv_allow_selfie_check? &&
+      resolved_authn_context_result.biometric_comparison? &&
       !current_user.identity_verified_with_biometric_comparison?
   end
 end
diff --git a/app/controllers/concerns/idv_step_concern.rb b/app/controllers/concerns/idv_step_concern.rb
@@ -111,7 +111,9 @@ def flow_policy
 
   def confirm_step_allowed
     # set it everytime, since user may switch SP
-    idv_session.selfie_check_required = decorated_sp_session.biometric_comparison_required?
+    idv_session.selfie_check_required =
+      FeatureManagement.idv_allow_selfie_check? &&
+      resolved_authn_context_result.biometric_comparison?
     return if flow_policy.controller_allowed?(controller: self.class)
 
     redirect_to url_for_latest_step

diff --git a/app/controllers/idv/by_mail/request_letter_controller.rb b/app/controllers/idv/by_mail/request_letter_controller.rb
@@ -15,7 +15,6 @@ class RequestLetterController < ApplicationController
       def index
         @applicant = idv_session.applicant
         @presenter = RequestLetterPresenter.new(current_user, url_options)
-        @step_indicator_current_step = step_indicator_current_step
 
         Funnel::DocAuth::RegisterStep.new(current_user.id, current_sp&.issuer).
           call(:usps_address, :view, true)
@@ -63,14 +62,6 @@ def confirm_profile_not_too_old
         redirect_to idv_path if gpo_mail_service.profile_too_old?
       end
 
-      def step_indicator_current_step
-        if resend_requested?
-          :get_a_letter
-        else
-          :verify_phone_or_address
-        end
-      end
-
       def update_tracking
         Funnel::DocAuth::RegisterStep.new(current_user.id, current_sp&.issuer).
           call(:usps_letter_sent, :update, true)
@@ -139,6 +130,14 @@ def send_reminder
       def pii_locked?
         !Pii::Cacher.new(current_user, user_session).exists_in_session?
       end
+
+      def step_indicator_steps
+        if in_person_proofing?
+          Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS_GPO
+        else
+          StepIndicatorConcern::STEP_INDICATOR_STEPS_GPO
+        end
+      end
     end
   end
 end
diff --git a/app/controllers/idv/confirm_start_over_controller.rb b/app/controllers/idv/confirm_start_over_controller.rb
@@ -11,13 +11,13 @@ class ConfirmStartOverController < ApplicationController
     before_action :confirm_idv_needed
 
     def index
-      @step_indicator_step = requested_letter_before? ? :get_a_letter : :verify_phone_or_address
+      @step_indicator_step = requested_letter_before? ? :verify_address : :verify_phone
 
       analytics.idv_gpo_confirm_start_over_visited
     end
 
     def before_letter
-      @step_indicator_step = requested_letter_before? ? :get_a_letter : :verify_phone_or_address
+      @step_indicator_step = requested_letter_before? ? :verify_address : :verify_phone
 
       analytics.idv_gpo_confirm_start_over_before_letter_visited
     end

diff --git a/app/controllers/idv/document_capture_controller.rb b/app/controllers/idv/document_capture_controller.rb
@@ -43,6 +43,10 @@ def update
     end
 
     def extra_view_variables
+      doc_auth_selfie_capture =
+        FeatureManagement.idv_allow_selfie_check? &&
+        resolved_authn_context_result.biometric_comparison?
+
       {
         document_capture_session_uuid: document_capture_session_uuid,
         flow_path: 'standard',
@@ -51,7 +55,7 @@ def extra_view_variables
         skip_doc_auth: idv_session.skip_doc_auth,
         skip_doc_auth_from_handoff: idv_session.skip_doc_auth_from_handoff,
         opted_in_to_in_person_proofing: idv_session.opted_in_to_in_person_proofing,
-        doc_auth_selfie_capture: decorated_sp_session.biometric_comparison_required?,
+        doc_auth_selfie_capture:,
       }.merge(
         acuant_sdk_upgrade_a_b_testing_variables,
       )
@@ -90,15 +94,19 @@ def cancel_establishing_in_person_enrollments
     end
 
     def analytics_arguments
+      liveness_checking_required =
+        FeatureManagement.idv_allow_selfie_check? &&
+        resolved_authn_context_result.biometric_comparison?
+
       {
         flow_path: flow_path,
         step: 'document_capture',
         analytics_id: 'Doc Auth',
         irs_reproofing: irs_reproofing?,
         redo_document_capture: idv_session.redo_document_capture,
         skip_hybrid_handoff: idv_session.skip_hybrid_handoff,
-        liveness_checking_required: decorated_sp_session.biometric_comparison_required?,
-        selfie_check_required: idv_session.selfie_check_required,
+        liveness_checking_required:,
+        selfie_check_required: liveness_checking_required,
       }.merge(ab_test_analytics_buckets)
     end