LG-12770: Update Translations to ensure better understanding in other languages. #10461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiarra3
force-pushed
the
LG-12770-translations-update
branch
from
f993e4e to
3ff3eb9
Compare
|
I'm guessing we don't need all of the revisions from the tracking spreadsheet because those were updated in #10323, is that right? |
aduth
approved these changes
Apr 18, 2024
YUP! These were the only ones that werent updated yet. |
|
Since #10291 is now merged, can we rebase this and add Chinese translations? The build may fail without them as well. |
aduth
reviewed
May 3, 2024
aduth
approved these changes
May 3, 2024
config/locales/forms/zh.yml
Outdated
| learn_more: Learn more about security keys | ||
| nickname: 安全密钥昵称 | ||
| saving: 正在保存你的凭据… | ||
| set_up: Set up security key | ||
| set_up: 设置安全密钥 | ||
| step_1: Give it a nickname |
There was a problem hiding this comment.
Do we know if these remaining strings are accounted for in another ticket?
There was a problem hiding this comment.
I just pinged the team to let them know. its in the acceptance for this ticket.
… languages changelog: User-Facing Improvements, Authentication, update language to DoS standards update form language address lqa comment 308 translations for Zh normalize yaml remove translated keys froms pec mfa info removed
This refers to a button below where the label is expected to be translated to Spanish
aduth
force-pushed
the
LG-12770-translations-update
branch
from
3d88b13 to
1b4ae23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-12770