Increase strictness and improve ability to keep internationalization tests up-to-date #10508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests up-to-date changelog: Internal, Internationalization, Increase strictness and improve ability to keep internationalization tests up-to-date
mitchellhenke
commented
Apr 25, 2024
| @@ -68,15 +60,21 @@ def untranslated_key?(key, base_locale_value) | |||
| node = data[current_locale].first.children[key] | |||
| next unless node&.value&.is_a?(String) | |||
| next if node.value.empty? | |||
| next if allowed_untranslated_key?(current_locale, key) | |||
| node.value == base_locale_value | |||
| next unless node.value == base_locale_value | |||
There was a problem hiding this comment.
I swapped the conditionals here so that we only check whether a key is allowed to be untranslated in the case where we have a match on values. This removes some unnecessary checks and also helps with the tracking of unused allowed untranslated keys.
mitchellhenke
force-pushed
the
mitchellhenke/improve-i18n-test-strictness
branch
from
f84d513 to
675e9ed
Compare
zachmargolis
approved these changes
Apr 25, 2024
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
While working on #10291, I was working on some improvements to the i18n tests and pulled them out here to make them easier to review. This PR makes a few changes:
The above will hopefully help in keeping the list of exceptions up-to-date.
I've also made some smaller changes to the checks in
allowed_untranslated_key?so that we don't use a Regexp unless it is explicitly one, and otherwise use strict equality.