Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG-12706: Include user_id in piv_cac_login event #10584

Merged
merged 2 commits into from
May 14, 2024
Merged

LG-12706: Include user_id in piv_cac_login event #10584

merged 2 commits into from
May 14, 2024

Conversation

aduth
Copy link
Contributor

@aduth aduth commented May 10, 2024

🎫 Ticket

LG-12706

🛠 Summary of changes

Updates logging of piv_cac_login to ensure that a non-nil user_id is included in the logged result.

📜 Testing Plan

  1. Run EVENT_NAME=piv_cac_login make watch_events in a separate terminal process to the IdP
  2. Go to http://localhost:3000
  3. Click "Sign in with your government employee ID"
  4. Sign in with PIV
  5. Observe log entry "piv_cac_login" has a user_id for the user which logged in

@aduth
LG-12706: Include user_id in piv_cac_login event
309751f 
changelog: Internal, Analytics, Include user_id in piv_cac_login event
@aduth aduth requested a review from a team May 10, 2024 13:46
@aduth aduth marked this pull request as draft May 10, 2024 20:34
@aduth aduth marked this pull request as ready for review May 14, 2024 12:46
kevinsmaster5
kevinsmaster5 approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-05-14 at 8 55 30 AM LGTM 👍

@aduth aduth merged commit ff97682 into main May 14, 2024
2 checks passed
@aduth aduth deleted the aduth-lg-12706-piv-login-user-id branch May 14, 2024 13:23
@amirbey amirbey mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsmaster5 kevinsmaster5 kevinsmaster5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aduth @kevinsmaster5