Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agnes/lg 13018 billing report v2 #10613

Merged
merged 22 commits into from
May 13, 2024
Merged

Conversation

samathad2023
Copy link
Contributor

🎫 Ticket

Link to the relevant ticket:
LG-13018

🛠 Summary of changes

Created new combined invoice report v2 with partner details along with profile age.This new report will help login.gov to see partner billing details.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

  • Verified new report creation with spec file
  • Verified ial 1 shows no partner details
  • Verified Ial 2 with different partners and different profile age

@ThatSpaceGuy ThatSpaceGuy marked this pull request as ready for review May 13, 2024 20:02
Copy link
Contributor

@ThatSpaceGuy ThatSpaceGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the hard work, @samathad2023 and @colter-nattrass!

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one last comment update but otherwise good to go

ThatSpaceGuy and others added 2 commits May 13, 2024 15:37
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@samathad2023 samathad2023 merged commit a0e8cc6 into main May 13, 2024
2 checks passed
@samathad2023 samathad2023 deleted the agnes/lg-13018-billing-report-v2 branch May 13, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants