Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LG-13317: Log 10-digit OTP A/B test params for OTP sends #10621

Merged
merged 2 commits into from
May 14, 2024

Conversation

solipet
Copy link
Contributor

@solipet solipet commented May 14, 2024

🎫 Ticket

Link to the relevant ticket:
LG-13317

🛠 Summary of changes

Adds the ab_tests hash to the OTP sent event.

[skip changelog]

Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov>
@solipet solipet requested review from mitchellhenke and a team May 14, 2024 15:26
Copy link
Contributor

@jmhooper jmhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM though I expect we'll need changes to the analytics regression tests.

@solipet solipet force-pushed the dprice-lg-13317-track-ab-test-on-otp-sends branch from 0d4c7d2 to 9b209cc Compare May 14, 2024 17:17
@solipet solipet merged commit 2207d35 into main May 14, 2024
2 checks passed
@solipet solipet deleted the dprice-lg-13317-track-ab-test-on-otp-sends branch May 14, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants