Add SS1 record setFieldText and findLineItemValue. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulclarkaranz
commented
Nov 22, 2018
The `setFieldText` is NOT the same implementation as in NetSuite. There if you use `setFieldText` and then `getFieldValue` on an optionset field you will get an integer back, here you will get a string back. This is fine form my purposes though and is the same as the implementation in the SS2 module[1]. The `findLineItemValue` is very similar to the other *LineItem* methods but I thought I would add a test for it anyway for good luck. [1]: https://github.com/3EN-Cloud/netsumo/blob/0b4ff26c7645f2e5d531c314b06b550d7389def9/modules/SS2/Record.js#L86
Previously doing:
```
var record = nlobjRecord('customer', 1234)
record.selectNewLineItem('addressbook')
record.setCurrentLineItemValue('addressbook', 'attention', 'Sam')
record.commitLineItem('addressbook')
record.selectLineItem('addressbook', 1)
record.setCurrentLineItemValue('addressbook', 'attention', 'Tom')
record.commitLineItem('addressbook')
nlapiSubmitRecord(record)
```
Would have added to new address to the record instead of adding one and
then modifying it, what is what happens in NetSuite.
paulclarkaranz
force-pushed
the
ss1_settext_findvalue
branch
from
c02999b to
330a467
Compare
paulclarkaranz
added a commit
to seequent/netsumo
that referenced
this pull request
Nov 26, 2018
Similar to in 3EN-Cloud#12, add `setCurrentLineItemText` to set line item list fields by display string. And the same caveat applies, getting the value later won't return the index like it would in NetSuite.
paulclarkaranz
added a commit
to seequent/netsumo
that referenced
this pull request
Nov 26, 2018
Similar to in 3EN-Cloud#12, add `setCurrentLineItemText` to set line item list fields by display string. And the same caveat applies, getting the value later won't return the index like it would in NetSuite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setFieldTextis NOT the same implementation as in NetSuite. There if you usesetFieldTextand thengetFieldValueon an optionset field you will get an integer back, here you will get a string back. This is fine form my purposes though and is the same as the implementation in the SS2 module.The
findLineItemValueis very similar to the other *LineItem* methods but I thought I would add a test for it anyway for good luck.I have taken ownership of some SS1 code with no tests around it so you might see some more contributions like this from me in the future, if you are open to them. I'm not actually aware of any trends regard SS2 vs SS1, should I be porting v1 code to v2?
edit: I pushed a couple of fixes for issues I ran across.