Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas change append -> concat (tusharedownloader.py,processor_wrds.py and FinRL_PaperTrading_Demo.ipynb) #1087

Merged

Conversation

skon7
Copy link
Contributor

@skon7 skon7 commented Sep 1, 2023

Tages:

@xiaoyang

Issue :

#1078 (Help with: AttributeError: 'DataFrame' object has no attribute 'account_value)

Description

This pull request addresses issue #1078 by replacing the append function with the concat function. The issue was caused by a compatibility problem with pandas versions greater than 2.

Changes Made

  • Replaced append with concat in relevant code sections tusharedownloader.py , processor_wrds.py also the same bug for FinRL_PaperTrading_Demo.ipynb.
  • Chnage SQL query in line 57 of processor_wrds.py file to pass flaske8 because it failed with this message finrl/meta/data_processors/processor_wrds.py:57:128: E501 line too long (145 > 127 characters) 1 E501 line too long (145 > 127 characters) but now passed .

@zhumingpassional
Copy link
Collaborator

yes.
thanks for your codes. good

@zhumingpassional zhumingpassional merged commit cf9aa66 into AI4Finance-Foundation:master Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants