Skip to content

Commit

Permalink
Lin. Solvers (MLMG): Include Order (#1496)
Browse files Browse the repository at this point in the history
## Summary

Include own headers before stdlib headers to catch missing includes early. This avoid problems with less common compilers and environments.

Carved out of #1485

## Additional background

## Checklist

The proposed changes:
- [ ] fix a bug or incorrect behavior in AMReX
- [ ] add new capabilities to AMReX
- [ ] changes answers in the test suite to more than roundoff level
- [ ] are likely to significantly affect the results of downstream AMReX users
- [ ] are described in the proposed changes to the AMReX documentation, if appropriate
  • Loading branch information
ax3l authored Nov 3, 2020
1 parent ee3076a commit 24cacef
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 13 deletions.
5 changes: 3 additions & 2 deletions Src/LinearSolvers/MLMG/AMReX_MLCGSolver.H
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
#ifndef AMREX_MLCGSOLVER_H_
#define AMREX_MLCGSOLVER_H_

#include <cmath>

#include <AMReX_Vector.H>
#include <AMReX_MultiFab.H>
#include <AMReX_MLLinOp.H>

#include <cmath>


namespace amrex {

class MLMG;
Expand Down
11 changes: 6 additions & 5 deletions Src/LinearSolvers/MLMG/AMReX_MLCGSolver.cpp
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@

#include <limits>
#include <algorithm>
#include <iomanip>
#include <cmath>

#include <AMReX_ParmParse.H>
#include <AMReX_Utility.H>
#include <AMReX_LO_BCTYPES.H>
Expand All @@ -16,6 +11,12 @@
#include <omp.h>
#endif

#include <limits>
#include <algorithm>
#include <iomanip>
#include <cmath>


namespace amrex {

namespace {
Expand Down
10 changes: 6 additions & 4 deletions Src/LinearSolvers/MLMG/AMReX_MLLinOp.cpp
Original file line number Diff line number Diff line change
@@ -1,8 +1,4 @@

#include <cmath>
#include <algorithm>
#include <unordered_map>
#include <set>
#include <AMReX_Utility.H>
#include <AMReX_MLLinOp.H>
#include <AMReX_MLCellLinOp.H>
Expand All @@ -19,6 +15,12 @@
#include <AMReX_PETSc.H>
#endif

#include <algorithm>
#include <cmath>
#include <set>
#include <unordered_map>


namespace amrex {

#if __cplusplus < 201703L
Expand Down
5 changes: 3 additions & 2 deletions Src/LinearSolvers/MLMG/AMReX_MLNodeLaplacian.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#include <limits>

#include <AMReX_MLMG.H>
#include <AMReX_MLNodeLaplacian.H>
#include <AMReX_MLNodeLap_K.H>
Expand All @@ -14,6 +12,9 @@
#include <omp.h>
#endif

#include <limits>


namespace amrex {

MLNodeLaplacian::MLNodeLaplacian (const Vector<Geometry>& a_geom,
Expand Down

0 comments on commit 24cacef

Please sign in to comment.