Adopt MIAF shared constraints #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leo-barnes
requested review from
cconcolato,
wantehchang,
podborski and
y-guyon
leo-barnes
commented
Sep 12, 2024
y-guyon
approved these changes
Sep 12, 2024
See the comment inline. The reason MIAF did it this way is so that you can create a generic non-profiled MIAF file as well as MIAF files under specific profiles. |
Oh okay, I did not connect the two things. It makes sense now. |
leo-barnes
force-pushed
the
u/lbarnes/adopt_constraints
branch
from
b16e9cc to
ed4fdcb
Compare
leo-barnes
force-pushed
the
u/lbarnes/adopt_constraints
branch
from
acc68f6 to
4215905
Compare
github-actions bot
added a commit
that referenced
this pull request
Sep 25, 2024
SHA: 1796dae Reason: push, by leo-barnes Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #169
Preview | Diff