Add property based testing for FolderStorage #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirillt
reviewed
Aug 18, 2024
Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com>
|
After experimenting with various synchronization models for concurrent operations, the "StrongDelete" approach is coming out to be the most effective in terms of code complexity and efficiency with passing tests. The synchronization model can be stated as below -
|
twitu
added a commit
that referenced
this pull request
Sep 2, 2024
* init Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * added tests Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * few fixes Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fmt Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * Add property based testing for FolderStorage (#86) * Add property test * Use print statements * experimental changes Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * Refactor to remove unwraps * Fix folderstorage model with strong deletes --------- Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> Co-authored-by: pushkarm029 <pushkarmishra029@gmail.com> * Fix formatting * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * remove bincode Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> * Change folderstorage file extension to json * fix Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> --------- Signed-off-by: pushkarm029 <pushkarmishra029@gmail.com> Co-authored-by: Ishan Bhanuka <bhanuka.ishan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test checks whether the following invariants holds -
Currently the test fails indicating some subtle bug in the implementation. Relaxing the properties or fixing the implementation are two possible ways to get the test passing. @Pushkarm029