Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eccodes support #52

Closed
brancomat opened this issue Mar 14, 2018 · 5 comments
Closed

eccodes support #52

brancomat opened this issue Mar 14, 2018 · 5 comments
Assignees
Labels

Comments

@brancomat
Copy link
Member

The current configure.ac looks explicitely for grib_api

It should consider eccodes too, as arkimet already does.

(I'm not sure of the implications, will that suffice?)

@brancomat
Copy link
Member Author

Done by @dcesari , but keeping the bug open with the "review" label until tested

@brancomat
Copy link
Member Author

Almost everything works as expected supporting both grib_api and eccodes BUT there's an issue in libsim.pc.in:
https://github.com/ARPA-SIMC/libsim/blob/master/libsim.pc.in#L13

Requires.private: log4c gdal libdballef grib_api_f90 netcdf-fortran

This generate a conflict (requires grib_api as a dependency of libsim-devel even when compiled with eccodes)

grib_api_f90 should be dynamically changed to eccodes_f90 when eccodes is detected. But I'm not sure how to do it.

@edigiacomo
Copy link
Member

I'm testing a patch.

@edigiacomo
Copy link
Member

Commit f0f98be should fix the problem.

@edigiacomo
Copy link
Member

The fix should work. From https://api.travis-ci.org/v3/job/428049075/log.txt:

Provides: libsim-devel = 6.2.8-1 libsim-devel(x86-64) = 6.2.8-1 libtool(/usr/lib64/liblog4fortran.la) libtool(/usr/lib64/libsim_alchimia.la) libtool(/usr/lib64/libsim_base.la) libtool(/usr/lib64/libsim_graphics.la) libtool(/usr/lib64/libsim_qc.la) libtool(/usr/lib64/libsim_termolib.la) libtool(/usr/lib64/libsim_vol7d.la) libtool(/usr/lib64/libsim_volgrid6d.la) pkgconfig(libsim) = 6.2.8
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: /usr/bin/pkg-config liblog4fortran.so.6()(64bit) libsim_alchimia.so.6()(64bit) libsim_base.so.6()(64bit) libsim_graphics.so.6()(64bit) libsim_qc.so.6()(64bit) libsim_termolib.so.6()(64bit) libsim_vol7d.so.6()(64bit) libsim_volgrid6d.so.6()(64bit) pkgconfig(eccodes_f90) pkgconfig(gdal) pkgconfig(libdballef) pkgconfig(log4c) pkgconfig(netcdf-fortran)

@dcesari dcesari closed this as completed Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants