Abris #240 use spark avro encoder writer #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinwallimann Binary Compatibility is failing as expected, since we are preparing new major version I disabled it for now. |
| } | ||
|
|
||
| private def wrapSchemaIfNeeded(schema: Schema) = { |
There was a problem hiding this comment.
Why is this not needed anymore?
There was a problem hiding this comment.
I am not sure what was causing the need for it in the first place. May suspicion is that the old code was sometime generating a bare schema.
Bare schema is just a name of the type without any record. Such a schema is not possible to register in the schema registry. I think the new schema generation code should never return it, and the only place when it could occur is when someone provides it directly. To keep Abris consistent with spark avro I choose to remove this.
- use spark avro writer and encoder - remove custom encoder and writer and other unused code
cerveada
force-pushed
the
feature/abris-240-switch-to-spark-avro-encoder
branch
from
d846d0f to
d176ed4
Compare
kevinwallimann
approved these changes
Nov 15, 2021
gintautassulskus-elsevier
pushed a commit
to gintautassulskus-elsevier/ABRiS
that referenced
this pull request
Feb 4, 2022
- use spark avro writer and encoder - remove custom encoder and writer and other unused code
ScaddingJ
pushed a commit
to ScaddingJ/ABRiS
that referenced
this pull request
Mar 8, 2022
- use spark avro writer and encoder - remove custom encoder and writer and other unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #240