Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for Abris 5 #253

Merged
merged 2 commits into from
Nov 25, 2021
Merged

add documentation for Abris 5 #253

merged 2 commits into from
Nov 25, 2021

Conversation

cerveada
Copy link
Collaborator

  • remove unused dependencies
  • remove prints in test

- remove unused dependencies
- remove prints in test
@cerveada cerveada marked this pull request as ready for review November 23, 2021 14:32
README.md Outdated
This means the Spark schema doesn't need to be changed (to non-nullable columns) for avro conversion to succeed.

## Confluent Schema Registry Version
Abris by default uses Confluent client version 5.3.4, but any newer version should work.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can any newer version of Confluent work? I thought the compatibility problem between Confluent v5.4.+ and Spark will only be resolved with Avro 1.10 in Spark 3.2.0

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the Abris side it should work, but yes there might be issues elsewhere. I think that it may work if you changed the avro in Spark to the one compatible with schema registry. I am not sure how hard is it to change the libraries that spark is using.

Maybe I should remove that part and just keep the confluent 5.3 as recommended version until Spark 3.2-Abris is ready.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the situation has not changed compared to #165. If you look at the issue there, we figured out that the problem was the Avro version. Since we didn't follow up on a solution to that, I wouldn't add it here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then I wall remove it from release notes as well, so people don't think that everything will work

@cerveada cerveada merged commit 60c7681 into master Nov 25, 2021
@cerveada cerveada deleted the documentation-for-v5 branch November 25, 2021 10:40
gintautassulskus-elsevier pushed a commit to gintautassulskus-elsevier/ABRiS that referenced this pull request Feb 4, 2022
* add documentation for Abris 5

- remove unused dependencies
- remove prints in test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants