Abris #256 support for Scala 2.13 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I saw these two deprecation warnings
- ConfluentKafkaAvroReader.scala:59: warning: symbol literal is deprecated; use Symbol("data") instead
- ConfluentKafkaAvroWriter.scala:62: warning: symbol literal is deprecated; use Symbol("value") instead
Actually, there are a lot more instances of this in the tests.
Also this
- CatalystAvroConversionSpec.scala:54: warning: procedure syntax is deprecated: instead, add
: Unit =to explicitly declarebeforeEach's return type - SchemaEvolutionSpec.scala:43: warning: procedure syntax is deprecated: instead, add
: Unit =to explicitly declarebeforeEach's return type
You can get the complete output with
mvn clean test -Pspark-3.2,scala-2.13 -DaddScalacArgs=-deprecation
- apache.commons.io deprecation removed - scalatest deprecation removed - test libraries updated to the latest minor version
kevinwallimann
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #256