Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The mathHelperName parameter in the makeIssuerKit method should be declared optional. #1373

Closed
katelynsills opened this issue Aug 5, 2020 · 0 comments · Fixed by #1674
Closed

The mathHelperName parameter in the makeIssuerKit method should be declared optional. #1373

katelynsills opened this issue Aug 5, 2020 · 0 comments · Fixed by #1674
Assignees
@Chris-Hibbert
Labels
ERTP package: ERTP

Comments

@katelynsills
Copy link
Contributor

The mathHelperName parameter in the makeIssuerKit method should be declared optional.

Originally posted by @erights in #1357
@erights erights mentioned this issue Aug 8, 2020
Closed
@katelynsills katelynsills added the ERTP package: ERTP label Aug 11, 2020
@Chris-Hibbert Chris-Hibbert self-assigned this Aug 12, 2020
Chris-Hibbert added a commit that referenced this issue Sep 2, 2020
@Chris-Hibbert
fix: declare amountMathKind parameter to makeissuerkit optional
f42bcc3 
The mathHelperName was changed to amountMathKind, and it's optional in
the code. This updates the type declaration to match.

fixes: #1373
@Chris-Hibbert Chris-Hibbert mentioned this issue Sep 2, 2020
Merged
Chris-Hibbert added a commit that referenced this issue Sep 3, 2020
@Chris-Hibbert
fix: declare amountMathKind parameter to makeissuerkit optional
0fce443 
The mathHelperName was changed to amountMathKind, and it's optional in
the code. This updates the type declaration to match.

fixes: #1373
Chris-Hibbert added a commit that referenced this issue Sep 3, 2020
@Chris-Hibbert
fix: declare amountMathKind parameter to makeissuerkit optional
a21832a 
The mathHelperName was changed to amountMathKind, and it's optional in
the code. This updates the type declaration to match.

fixes: #1373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
ERTP package: ERTP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: declare amountMathKind parameter to makeissuerkit optional Agoric/agoric-sdk
2 participants
@katelynsills @Chris-Hibbert