Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xsnap swingset worker does not support metering #2837

Closed
dckc opened this issue Apr 7, 2021 · 5 comments · Fixed by #2995
Closed

xsnap swingset worker does not support metering #2837

dckc opened this issue Apr 7, 2021 · 5 comments · Fixed by #2995
Assignees
@warner @dckc
Labels
bug Something isn't working SwingSet package: SwingSet xsnap the XS execution tool

Comments

@dckc
Copy link
Member

dckc commented Apr 7, 2021

To Reproduce

Steps to reproduce the behavior:

  1. in packages/zoe run yarn test:xs-worker
  2. See xsnap worker does not support enableInternalMetering and TODO: support metered with xs-worker; using local as work-around
@dckc dckc added bug Something isn't working SwingSet package: SwingSet labels Apr 7, 2021
dckc pushed a commit that referenced this issue Apr 7, 2021
test(swingset): reduce redundancy in test:xs-worker
f7588ce 
note that test-crashingContract.js fails due to lack of
metering support in the xs-worker (#2837)
@dckc dckc mentioned this issue Apr 7, 2021
Closed
@dckc dckc self-assigned this Apr 7, 2021
dckc pushed a commit that referenced this issue Apr 9, 2021
@dckc
test(swingset): reduce redundancy in test:xs-worker
287b01b 
note that test-crashingContract.js fails due to lack of
metering support in the xs-worker (#2837)
dckc pushed a commit that referenced this issue Apr 9, 2021
@dckc
test(swingset): reduce redundancy in test:xs-worker
dfe17b3 
note that test-crashingContract.js fails due to lack of
metering support in the xs-worker (#2837)
@dckc dckc added this to the Beta Phase 3: Metering & Transaction Costs milestone Apr 9, 2021
@dckc
Copy link
Member Author

dckc commented Apr 9, 2021

@warner I meant to get your OK on postponing this part before closing #2605 ...

when I said all the zoe tests are passing on XS, I neglected to say that's only the unit tests and not the swingset tests. I postponed running the zoe swingset tests on XS because they seem to rely on metering in XS.

@dckc
Copy link
Member Author

dckc commented Apr 9, 2021

oh... maybe this is a dup of #2322

@dckc dckc mentioned this issue Apr 13, 2021
Closed
@warner warner added the xsnap the XS execution tool label Apr 26, 2021
@dckc
Copy link
Member Author

dckc commented Apr 27, 2021

yarn test:xs-worker in packages/zoe works now: 18 tests passed.

Are we there yet? Shall I close this, @warner ? Or should we add test:xs-worker to test:xs in packages/zoe/package.json?

Or do you want to use this issue to track allocation?

@dckc dckc mentioned this issue Apr 29, 2021
Merged
1 task
@warner
Copy link
Member

warner commented Apr 29, 2021

We're tracking allocation now, right? If so, then yes let's close this. If not, let's leave it open until we're protecting against runaway allocation.

@dckc
Copy link
Member Author

dckc commented Apr 29, 2021

We're tracking allocation now, right?

Yes.

@dckc dckc closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warner warner

@dckc dckc

Labels
bug Something isn't working SwingSet package: SwingSet xsnap the XS execution tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: default to xs-worker in chain Agoric/agoric-sdk
2 participants
@warner @dckc