Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate s:stake-bld to z:acceptance #10835

Merged
merged 3 commits into from
Jan 15, 2025
Merged

migrate s:stake-bld to z:acceptance #10835

merged 3 commits into from
Jan 15, 2025

Conversation

anilhelvaci
Copy link
Collaborator

@anilhelvaci anilhelvaci commented Jan 13, 2025 •
edited
Loading

closes: #10818

Description

#10818 talks about moving tests in a3p-integration/proposals/s:stake-bld to z:acceptance. This PR makes it happen.

Security Considerations

No security concerns.

Scaling Considerations

No scaling concerns.

Documentation Considerations

No need for documentation.

Testing Considerations

Integration tests should pass in CI.

Upgrade Considerations

This PR makes sure upcoming proposals don't break basic orchestration functionality.

@anilhelvaci anilhelvaci added the force:integration Force integration tests to run on PR label Jan 13, 2025
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 13, 2025 •
edited
Loading

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8eae20c
Status: ✅  Deploy successful!
Preview URL: https://b9e3b384.agoric-sdk.pages.dev
Branch Preview URL: https://anil-10818-migrate-stk-bld.agoric-sdk.pages.dev

View logs

@anilhelvaci anilhelvaci force-pushed the anil/10818-migrate-stk-bld branch from 125bc46 to 8475ea9 Compare January 13, 2025 08:29
@anilhelvaci anilhelvaci marked this pull request as ready for review January 13, 2025 09:43
@anilhelvaci anilhelvaci requested a review from a team as a code owner January 13, 2025 09:43
@anilhelvaci anilhelvaci force-pushed the anil/10818-migrate-stk-bld branch from 8475ea9 to ef67242 Compare January 14, 2025 12:45
@turadg turadg mentioned this pull request Jan 14, 2025
Open
@anilhelvaci anilhelvaci added the automerge:rebase Automatically rebase updates, then merge label Jan 15, 2025
@anilhelvaci
chore(acceptance): move stakeBld.test.js, apply patches
0a40e79 
work around endo compatibility of cosmjs packages

refs: #10818
@anilhelvaci
chore(acceptance): remove s:stake-bld
a4a4683 
refs: #10818

fix: remove eval.sh from z:acceptance

fix(acceptance): document incompatible `axios` and `protobufjs`
@anilhelvaci
chore(acceptance): document misnaming validator address
8eae20c 
refs: Agoric/agoric-3-proposals#212
refs: #10818
@anilhelvaci anilhelvaci force-pushed the anil/10818-migrate-stk-bld branch from cb7e351 to 8eae20c Compare January 15, 2025 09:44
@mergify mergify bot merged commit 9f46b37 into master Jan 15, 2025
81 checks passed
@mergify mergify bot deleted the anil/10818-migrate-stk-bld branch January 15, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

@AgoricTriage AgoricTriage Awaiting requested review from AgoricTriage AgoricTriage is a code owner automatically assigned from Agoric/engprodexec

@Chris-Hibbert Chris-Hibbert Awaiting requested review from Chris-Hibbert

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge force:integration Force integration tests to run on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate s:stake-bld to z:acceptance
2 participants
@anilhelvaci @turadg