Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ertp,zoe): minimal want patterns using M.containerHas(el,n) #10952

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

erights
Copy link
Member

@erights erights commented Feb 5, 2025

#endo-branch: markm-m-has-matcher

closes: #XXXX
refs: endojs/endo#2710 #1905 #1913 #1915 #2155 #2156 #2230 #4212 #4217 #10951

Description

Implements minimal want patterns, where the only supported pattern is the M.has to be introduced by endojs/endo#2710

Depends on endojs/endo#2710

  • Zoe-level changes to accept want patterns

Security Considerations

none

Scaling Considerations

By allowing want patterns, might this make the processing of wants more expensive?

Documentation Considerations

Need to update ERTP docs to explain the use of M.has patterns in AmountMath.isGTE and AmountMath.subtract.

Testing Considerations

ERTP tests already added.

  • Need to add Zoe tests once the Zoe changes are in

Upgrade Considerations

None

  • Need to update NEWS.md for ERTP and Zoe

Copy link

cloudflare-workers-and-pages bot commented Feb 5, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1efc171
Status:🚫  Build failed.

View logs

@erights erights force-pushed the markm-min-want-patterns-3 branch 5 times, most recently from ffd5cdd to b2b30dc Compare February 11, 2025 01:38
@erights erights force-pushed the markm-min-want-patterns-3 branch 2 times, most recently from a2c8801 to b8ebc19 Compare March 13, 2025 21:39
@erights erights force-pushed the markm-min-want-patterns-3 branch from c69a6e9 to c1fbfcf Compare March 14, 2025 21:00
@erights erights force-pushed the markm-min-want-patterns-3 branch from c1fbfcf to 3698a77 Compare March 14, 2025 21:01
@erights erights changed the title feat(ertp,zoe): minimal want patterns using M.has(el,n) feat(ertp,zoe): minimal want patterns using M.containerHas(el,n) Mar 18, 2025
@erights erights force-pushed the markm-min-want-patterns-3 branch from a04ee47 to 20b287d Compare March 18, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant