feat(ertp,zoe): minimal want patterns using M.containerHas(el,n) #10952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
6d08dcc
|
| Status: | 🚫 Build failed. |
erights
force-pushed
the
markm-min-want-patterns-3
branch
5 times, most recently
from
ffd5cdd to
b2b30dc
Compare
erights
force-pushed
the
markm-min-want-patterns-3
branch
2 times, most recently
from
a2c8801 to
b8ebc19
Compare
2 tasks
erights
force-pushed
the
markm-min-want-patterns-3
branch
2 times, most recently
from
c1fbfcf to
3698a77
Compare
erights
changed the title
erights
force-pushed
the
markm-min-want-patterns-3
branch
from
a04ee47 to
20b287d
Compare
erights
added a commit
to endojs/endo
that referenced
this pull request
Mar 19, 2025
Closes: #XXXX Refs: #2002 #2008 #2113 #1739 Agoric/agoric-sdk#10952 ## Description This PR adds a new `M.containerHas(elementPatt, positiveBigint)` matcher, and exported `containerHasSplit` function. This is motivated to support Agoric/agoric-sdk#10952 , which introduces a minimal form of want pattern in terms of `M.containerHas`. - [x] Actually merging this must happen only after we've decided either to move forward with #2008 or to give up on it. Once a decision is made, and even before it is acted on, then this PR can move forward. (Any decision to move forward or not with #2008 should also consider changing the default of the feature flag introduced by #2002 .) ### Security Considerations none ### Scaling Considerations Might help due to early termination of the split operations, which Agoric/agoric-sdk#10952 uses for `AmountMath.isGTE`. ### Documentation Considerations Already doc-documents `M.containerHas` in the types.js file for `M`. That's probably good enough for this PR. The interesting documentation will be explaining want patterns in Agoric/agoric-sdk#10952 ### Testing Considerations Added tests for `M.containerHas` ### Compatibility Considerations The reason to postpone merging this PR until decisions are made on #2008 is that this PR will further expose `rankOrder` in the API, amplifying the danger that changing the string order will cause surprising observable changes. ### Upgrade Considerations This PR itself does not introduce any BREAKING changes or Upgrade issues. - [x] Update `NEWS.md` for user-facing changes.
erights
force-pushed
the
markm-min-want-patterns-3
branch
from
1efc171 to
27b3006
Compare
erights
force-pushed
the
markm-zoe-types-gardening
branch
from
bc8b038 to
bbd4873
Compare
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
erights
force-pushed
the
markm-min-want-patterns-3
branch
from
27b3006 to
6d08dcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#endo-branch: markm-clickable-stack-lines
Built on endojs/endo#2747
closes: #XXXX
refs: endojs/endo#2710 #1905 #1913 #1915 #2155 #2156 #2230 #4212 #4217 #10951
Description
Implements minimal want patterns, where the only supported pattern is
M.containerHasSecurity Considerations
none
Scaling Considerations
By allowing want patterns, might this make the processing of wants more expensive?
Documentation Considerations
Need to update ERTP docs to explain the use of
M.haspatterns inAmountMath.isGTEandAmountMath.subtract.Testing Considerations
ERTP tests already added.
Upgrade Considerations
None