fixup(golang/.../vstorage/keeper): report absolute values for metrics increase/decrease #11101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… increase/decrease closes: #11062
Deploying agoric-sdk with
|
| Latest commit: |
e72f034
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ddbec154.agoric-sdk.pages.dev |
| Branch Preview URL: | https://sliakh-11062-use-actual-size-8jzs.agoric-sdk.pages.dev |
siarhei-agoric
commented
Mar 11, 2025
| func ReportStoreSizeMetrics(k Keeper, sizeDelta float32) { | ||
| // reportStoreSizeMetrics exports store size increase/decrease metrics | ||
| // when Cosmos telemetry is enabled. | ||
| func (k Keeper) reportStoreSizeMetrics(increase int, decrease int) { |
There was a problem hiding this comment.
Using uint for increase and increase forces unnecessary type conversions later in the code, so I am going to stick to int here.
x/vstorage/keeper/keeper.go:242:31: cannot use len(key) + len(rawValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
x/vstorage/keeper/keeper.go:399:32: cannot use len(encodedKey) + len(oldRawValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
x/vstorage/keeper/keeper.go:403:29: cannot use len(types.EncodedNoDataValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
x/vstorage/keeper/keeper.go:403:60: cannot use len(oldRawValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
x/vstorage/keeper/keeper.go:409:28: cannot use len(newRawValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
x/vstorage/keeper/keeper.go:409:46: cannot use len(oldRawValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
x/vstorage/keeper/keeper.go:424:32: cannot use len(encodedAncestor) + len(types.EncodedNoDataValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
x/vstorage/keeper/keeper.go:436:29: cannot use len(encodedAncestor) + len(types.EncodedNoDataValue) (value of type int) as uint value in argument to k.reportStoreSizeMetrics
|
For reference, this PR replaces #11080 |
mhofman
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #11062
Description
We need to report absolute values for vstorage metrics increase/decrease as requested in #11063 (review)
Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
store_size_increaseandstore_size_decreasemetrics represent total writes and deletes issued respectively, which may differ from the total number of bytes committed/freed to/from the store due to the store's internal implementation.Testing Considerations
vstorage metricstest passed:Upgrade Considerations
N/A