Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate fast-usdc contract package #11113

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

separate fast-usdc contract package #11113

wants to merge 3 commits into from

Conversation

turadg
Copy link
Member

@turadg turadg commented Mar 13, 2025

refs: #10811

Description

#10811 was getting very big and will likely bit rot before it's all done.

This lands a key step in the migration by separating the contract package from the one going to NPM. Contracts are built from repositories and published to the chain and other artifact repositories. They aren't usable in the JS ecosystem so there's no reason to publish them to NPM.

Some benefits of the separation:

  • the @agoric/fast-usdc package is smaller
  • it can be imported in UI without pulling in Zoe and Liveslots
  • helps developers think about what changes will affect vats vs elsewhere

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

Our example dapps already have a separate contract dir (example) so this reduces the need for documentatio by aligning with that.

Testing Considerations

CI

Upgrade Considerations

no behavioral changes

@turadg turadg requested review from dckc and 0xpatrickdev March 13, 2025 00:20
@turadg turadg requested a review from a team as a code owner March 13, 2025 00:20
@turadg turadg marked this pull request as draft March 13, 2025 00:25
@turadg
Copy link
Member Author

turadg commented Mar 13, 2025

Dropped to draft while to solve this knot:

  • @agoric/builders depends on @agoric/fu-contract which I don't want to publish
  • @agoric/cosmic-swingset currently needs the builders in order to start a chain
  • @agoric/vm-config doesn't depend on the builders package but its JSON configs reference it

What I'll probably have to do is make cut the dependency of builders on fu-contract and make users of that do a little more work to get their fu-contract core-eval builds.

cc @michaelfig for other ideas

Copy link

cloudflare-workers-and-pages bot commented Mar 19, 2025

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7c77a50
Status: ✅  Deploy successful!
Preview URL: https://10771a8f.agoric-sdk.pages.dev
Branch Preview URL: https://10811-fu-contract.agoric-sdk.pages.dev

View logs

@turadg turadg added the force:integration Force integration tests to run on PR label Mar 19, 2025
@turadg turadg force-pushed the 10811-fu-contract branch from d6d05f3 to f6234b6 Compare March 19, 2025 21:56
@turadg turadg marked this pull request as ready for review March 19, 2025 23:12
@turadg turadg force-pushed the 10811-fu-contract branch 2 times, most recently from dea9c79 to f3cbd12 Compare March 21, 2025 17:24
@turadg turadg force-pushed the 10811-fu-contract branch from f3cbd12 to cd463a7 Compare March 21, 2025 22:06
@turadg turadg force-pushed the 10811-fu-contract branch from cd463a7 to 7c77a50 Compare March 21, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force:integration Force integration tests to run on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant