252 simplify parse account #11171
Merged
252 simplify parse account #11171
+137
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turadg
approved these changes
Mar 26, 2025
| @@ -670,7 +670,7 @@ export const makeChainHub = ( | |||
| * | |||
| * XXX consider accepting AmountArg #10449 | |||
| * | |||
| * @param {AccountIdArg} destination | |||
| * @param {AccountIdArg | string} destination | |||
There was a problem hiding this comment.
Suggested change
| * @param {AccountIdArg | string} destination | |
| * @param {AccountIdArg | Bech32Address} destination |
Comment on lines
113
to
116
| * namespace: string; | ||
| * reference: string; | ||
| * accountAddress: string; | ||
| * }} |
There was a problem hiding this comment.
I called it Caip10Record.
| export const parseAccountId = partialId => { | ||
| if (typeof partialId !== 'string' || !partialId.length) { | ||
| Fail`Empty accountId: ${q(partialId)}`; | ||
| export const parseAccountIdArg = partialId => { |
There was a problem hiding this comment.
"partial" case is no longer supported.
Suggested change
| export const parseAccountIdArg = partialId => { | |
| export const parseAccountIdArg = idArg => { |
| const parsed = parseAccountId(partialId); | ||
| if ('namespace' in parsed) { | ||
| // It is already fully qualified | ||
| if (partialId.split(':').length === 3) { |
There was a problem hiding this comment.
consider a comment "if it's already a CAIP-10, return it"
Chris-Hibbert
force-pushed
the
252-simplify-parseAccountId
branch
from
d522d23 to
35b5e68
Compare
Deploying agoric-sdk with
|
| Latest commit: |
36dee3c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f25bb3a4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://252-simplify-parseaccountid.agoric-sdk.pages.dev |
Chris-Hibbert
force-pushed
the
252-simplify-parseAccountId
branch
from
35b5e68 to
6b00e7a
Compare
Chris-Hibbert
added
the
automerge:rebase
mergify
bot
force-pushed
the
252-simplify-parseAccountId
branch
from
6b00e7a to
fbd361a
Compare
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You may have to fix your CI before adding the pull request to the queue again. If you want to requeue this pull request, you can post a |
mergify
bot
force-pushed
the
252-simplify-parseAccountId
branch
from
fbd361a to
36dee3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #11037
refs: #11146
Description
Since we widened our accountIds to
AccountIdArg, (see #11007) this updatesparseAccountId()to support it more cleanly (and renamed it toparseAccountIdArg()), added a separateparseAccountId()that parses CAIP-10 addresses to their constituent parts.ChainHub.resolveAccountId()andChainHub.makeChainAddreess(), which need to support bare bech32 addresses, no longer useparseAccountId.This grew out of #11037. (It replaces #11146, which tried to go in a different direction.)
Security Considerations
No impact.
Scaling Considerations
No impact.
Documentation Considerations
Automatically generated docs will be updated.
Testing Considerations
Adds tests
Upgrade Considerations
Internal utilities only. Shouldn't impact upgrade.