fix: add vatDecRef to kernel, offer to liveslots #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUDCo
approved these changes
Oct 27, 2020
In the future, when liveslots implements GC and discovers that a Presence has ceased to be referenced by the user-level vat code, it will call this function to decrement the kernel's reference count for the imported object's c-list entry. `vatDecRef` might be called at any time (although always in its own turn). The kernel will eventually add the decref information to a queue, to be processed between cranks. For now, the kernel only records the information if an option was set to enable it (for future unit tests). Most of this patch is the kernel-worker protocol wiring to allow child-process vat workers to deliver the decref back up to the kernel process. Liveslots does not use this yet. A future patch will switch it on. refs #1872
warner
force-pushed
the
1872-add-vatdecref
branch
from
464c386 to
f0721d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, when liveslots implements GC and discovers that a Presence has
ceased to be referenced by the user-level vat code, it will call this
function to decrement the kernel's reference count for the imported object's
c-list entry.
vatDecRefmight be called at any time (although always in its own turn).The kernel will eventually add the decref information to a queue, to be
processed between cranks. For now, the kernel only records the information if
an option was set to enable it (for future unit tests).
Most of this patch is the kernel-worker protocol wiring to allow
child-process vat workers to deliver the decref back up to the kernel
process.
Liveslots does not use this yet. A future patch will switch it on.
refs #1872