Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: liquidation test cases for adjusting vault and auction params #92

Merged
merged 2 commits into from
Apr 4, 2024
Merged

test: liquidation test cases for adjusting vault and auction params #92

merged 2 commits into from
Apr 4, 2024

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Apr 4, 2024 •
edited
Loading

The PR adds test cases for adjusting Vault and Auction Params.

The test cases are working fine in CI and locally.

To run the tests on local, follow the following steps:

  1. Initiate the local server with:
yarn dev
  1. Make sure the local chain is running:
docker run -d -p 26657:26657 -p 1317:1317 -p 9090:9090 ghcr.io/agoric/agoric-3-proposals:main
  1. Execute the tests using:
yarn test:e2e

@rabi-siddique rabi-siddique marked this pull request as draft April 4, 2024 03:06
@rabi-siddique rabi-siddique force-pushed the rs-liquidation-test-cases branch 3 times, most recently from 98b1740 to ba63d8b Compare April 4, 2024 10:03
@rabi-siddique rabi-siddique force-pushed the rs-liquidation-test-cases branch 4 times, most recently from 6b46d61 to 0e5487f Compare April 4, 2024 10:24
@rabi-siddique rabi-siddique force-pushed the rs-liquidation-test-cases branch from 0e5487f to 13cac3e Compare April 4, 2024 10:25
@rabi-siddique rabi-siddique marked this pull request as ready for review April 4, 2024 10:34
@rabi-siddique rabi-siddique requested a review from turadg April 4, 2024 10:39
turadg
turadg approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working for me locally. I see the video in CI shows it working so I'm approving but as a follow-up please come up with a set of instructions that works on other developers' machines.

I suspect the problem may have something to do with using agoric-3-proposals:main which is deprecated. The latest is latest.

@rabi-siddique rabi-siddique merged commit 2dbc4bb into Agoric:main Apr 4, 2024
2 checks passed
frazarshad added a commit that referenced this pull request Apr 22, 2024
@frazarshad
Revert "Merge pull request #92 from rabi-siddique/rs-liquidation-test…
00dd7fd 
…-cases"

This reverts commit 2dbc4bb, reversing
changes made to 4b3f497.
@frazarshad frazarshad mentioned this pull request Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rabi-siddique @turadg