[ASL2 PATCH] Replace xpmr.c '#define XPMR_VOX_HANGTIME' with a new conf var #430
+19
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InterLinked1
requested changes
Dec 5, 2024
channels/chan_usbradio.c
Outdated
| @@ -4712,6 +4715,9 @@ static void pmrdump(struct chan_usbradio_pvt *o) | |||
|
|
|||
| pd(o->rxdemod); | |||
| pd(o->rxcdtype); | |||
| if(o->rxcdtype == CD_XPMR_VOX) { | |||
InterLinked1
approved these changes
Dec 6, 2024
KB4MDD
reviewed
Dec 10, 2024
configs/samples/usbradio.conf.sample
Outdated
| @@ -69,6 +69,10 @@ | |||
| ; pp - from parallel port (Active high) | |||
| ; ppinvert - from the inverted parallel port (Active low) | |||
|
|
|||
| voxhangtime = 2000 ; If carrierfrom=vox, mS to wait detecting RX audio before setting rxcarrierdetect=0 | |||
There was a problem hiding this comment.
To match the other sample entries, this should start with a semi-colon.
…nf var The ASL2 change (from AllStarLink/ASL-Asterisk#34) did not get merged into the ASL3 source base. This commit effectivly pulls in those changes. From: David Gleason <david@allscan.info> Replace xpmr.c '#define XPMR_VOX_HANGTIME' with a new 'voxhangtime' cfg parameter set in usbradio.conf. When using usbradio in carrierfrom=vox mode this is the value the vox hang timer pChan->rxVoxTimer is set to in xpmr.c each time RX audio is detected. Making it configurable allows the default value of 2000mS to be reduced to a shorter time thereby preventing 2 seconds of silence being added to all node user transmissions. A value of 500mS seems to be much more optimal, and in my testing resulted in no false RX CD drops even when not talking. (xpmr.c's vox mode detects even quiet background noise and thereby supports reliable COS detection for radios that do not have a hardware COS line output.) Add the new voxhangtime parm to chan_usbradio.c chan_usbradio_pvt struct, store_config(), xpmr.c createPmrChannel(), xpmr.h t_pmr_chan struct, and to configs/rpt/usbradio.conf and configs/samples/usbradio.conf.sample.
KB4MDD
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ASL2 change (from AllStarLink/ASL-Asterisk#34) did not get merged into the ASL3 source base. This commit effectivly pulls in those changes.
From: David Gleason david@allscan.info
Replace xpmr.c '#define XPMR_VOX_HANGTIME' with a new 'voxhangtime' cfg parameter set in usbradio.conf. When using usbradio in carrierfrom=vox mode this is the value the vox hang timer pChan->rxVoxTimer is set to in xpmr.c each time RX audio is detected. Making it configurable allows the default value of 2000mS to be reduced to a shorter time thereby preventing 2 seconds of silence being added to all node user transmissions. A value of 500mS seems to be much more optimal, and in my testing resulted in no false RX CD drops even when not talking. (xpmr.c's vox mode detects even quiet background noise and thereby supports reliable COS detection for radios that do not have a hardware COS line output.)
Add the new voxhangtime parm to chan_usbradio.c chan_usbradio_pvt struct, store_config(), xpmr.c createPmrChannel(), xpmr.h t_pmr_chan struct, and to configs/rpt/usbradio.conf and configs/samples/usbradio.conf.sample.