app_rpt.c: Refactor handle_link_data() and handle_remote_data()

[mkmer]

This is a follow on to PR #470 which should not be delayed. Intent is to clean up the stuff I notice while hunting down the truncated message.

Eliminate copy of malloc char* to fixed length char*
update sprintf() to snprintf()
rpt_link.c: Calculate buffer size and malloc buffers. add function __get_buffer_size() to calculate buffer size required. add node count to __mklinklist()
add macro for OBUFSIZE and BUFSIZE calculation
eliminate finddelim() call as __mklinklist() now counts links.

[mkmer]

I will squash into a single commit once we are done reviewing it.

[mkmer]

Fixing up finddelim may not be possible. I think some of the instances are searching through non null terminated values (but I can't be sure right now). With numbers like 3 in the limit while strs[100].
The finddelim is all in one commit we can easily back out if we think it should hold off for another PR.

[Allan-N]

I'll take a look at the finddelim call sites tomorrow.

[Allan-N]

FYI : in .../asterisk/include/asterisk/utils.h I just found :

#define ARRAY_LEN(a) (size_t) (sizeof(a) / sizeof(0[a]))

So, when needed, we can use ARRAY_LEN(strs)

[Allan-N]

Looks like chan_echolink.c, chan_tlb.c, and chan_voter have their own copy/version of findelim() that all need the same help.

[mkmer]

Looks like chan_echolink.c, chan_tlb.c, and chan_voter have their own copy/version of findelim() that all need the same help.

I saw that when I was making the move.
I think (and will) do the channels in separate PR. 1 for each channel.
This PR is getting to be one of those threads you don't want to pull :) Just keeps going and going.

[KB4MDD]

Good - pending changes for @InterLinked1

[mkmer]

Go figure - a spelling error... I'll get after it.