Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_rpt.c: mutex around link activity macro #524

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

mkmer
Copy link
Collaborator

@mkmer mkmer commented Feb 28, 2025

At a minimum, we should be locking the write to the buffer just like every other one.
Without it, we may have flaky behavior executing the macro.

@mkmer mkmer added the bug Something isn't working label Feb 28, 2025
Copy link
Member

@InterLinked1 InterLinked1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick: "flakey" is misspelled in the commit message

Edit: "Activity" is also misspelled.

I do wonder if the codespell stuff would pick up. GitHub is not very good about ease of reviewing the commit message itself. Gerrit was much better for this. It doesn't seem to now - is there a way to do it with the check?

@mkmer
Copy link
Collaborator Author

mkmer commented Mar 1, 2025

https://www.merriam-webster.com/dictionary/flakey
Spell check thinks it's ok because it is....

@mkmer mkmer changed the title app_rpt.c: mutex around link activiy macro app_rpt.c: mutex around link activity macro Mar 1, 2025
@InterLinked1
Copy link
Member

https://www.merriam-webster.com/dictionary/flakey Spell check thinks it's ok because it is....

But activity wasn't. Is there a way to catch that?
Now that I think about it, even in the Asterisk project, a lot of commit messages have typos. I imagine it's more common for people to hastily throw that together at the end, even if they spend a lot of time on the code.

@mkmer
Copy link
Collaborator Author

mkmer commented Mar 1, 2025

Codespell is only running against the source. My browser gives me squiggles in the PR text but nothing is checking the commit messages.

@Allan-N Allan-N requested a review from InterLinked1 March 3, 2025 01:22
@Allan-N Allan-N merged commit 94aac3a into master Mar 3, 2025
3 checks passed
@mkmer mkmer deleted the issue515-part2 branch March 3, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants