Special char in URL #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onned in AmauryCarrade#14). * decode URL's path in request headers
|
👍 for wikipedia |
|
Works well for me (can be tested here). I'll test a bit more and then merge. |
|
Excepted for domains with special chars (such as http://académie-française.fr), it works well. So I'll merge :) . |
AmauryCarrade
added a commit
that referenced
this pull request
Jan 10, 2015
Fixed URLs with special chars not working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix issue with special char in URL such as Wikipedia (mentionned in #14).
While this seems to work with Wikipédia, further tests should be done to avoid regression.