-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace .get* with .query* #49
Conversation
Note that this is to close #18. And addresses AmpersandJS/ampersand#21 |
Is it worth keeping the variable names in both the code and examples as 'role' and 'rolename'? |
Since it's not semver compliant
I'm pretty much +1 on this, though it makes me a little uneasy deprecating role quite so quickly before we have a chance to migrate everything else. But maybe that's not a reasonable concern, I can just see some people potentially getting confused by this in the short term, but maybe that's worth it to just get past it. shrug. We just have to make sure we major version bump everything possibly affected by this change when they upgrade to the new version. |
We could just leave it working, but we'll break it at some point. In theory this is exactly what major version bumps are for. |
5056918
to
4e858fc
Compare
I think this is ready now. |
+1 from me! |
This isn't ready yet, we need to make corresponding changes to dom-bindings.
Note that I didn't keep
role
around making this a breaking change.I feel like this is worth doing because according to accessibility experts the way we were using
role
was bad.Also, that's what semver versioning is for, right? This will be a major version bump we publish it this way.