Update to 1.9.2 and enable tests. #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 3, 2022 17:15
… and resolve a static link issue.
skupr-anaconda
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes:
1.9.0to1.9.2.spdlog.spdlog-fmt-embedto build with similar options to conda-forge.Review Information
Source
https://github.com/gabime/spdlog/tree/v1.9.2
License
https://github.com/gabime/spdlog/blob/v1.9.2/LICENSE
MIT
Upstream Changes
https://github.com/gabime/spdlog/releases
I think the inclusion of gabime/spdlog#2035 may be necessary.
Issues
https://github.com/gabime/spdlog/issues
Most recent (and outstanding items) are enhancement or howto
requests. Nothing looks like it should stop us fro taking this.
Pins and Requireds
fmtneeds to be a recent version, I've selected8.1.1.Testing
Enabled author's tests. They pass when a windows test is patched to
allow a little slop in timing.
Closing Comments
Looks good. Mamba needs it. Let's take it!